-
Notifications
You must be signed in to change notification settings - Fork 1.9k
TensorFlow: Fixed shape issue where unknown shape will be induced from data. #2475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
test/Microsoft.ML.Tests/ScenariosWithDirectInstantiation/TensorflowTests.cs
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #2475 +/- ##
==========================================
+ Coverage 71.22% 71.23% +0.01%
==========================================
Files 788 788
Lines 141071 141131 +60
Branches 16118 16115 -3
==========================================
+ Hits 100484 100541 +57
- Misses 36120 36124 +4
+ Partials 4467 4466 -1
|
test/Microsoft.ML.Tests/ScenariosWithDirectInstantiation/TensorflowTests.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For (1), is it consistent to TF convention? #Resolved |
test/Microsoft.ML.Tests/ScenariosWithDirectInstantiation/TensorflowTests.cs
Outdated
Show resolved
Hide resolved
test/Microsoft.ML.Tests/ScenariosWithDirectInstantiation/TensorflowTests.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the case of one unknown dimension, yes. If there are more than one unknown dimension than there is no solution. This is just a way to it other way is to make a reshape transformer in ML.NET which user can use to define their input shape which then be mapped to TF shapes easily. In reply to: 461891682 [](ancestors = 461891682) |
This PR fixes #2458.
The problem addressed in this PR are