moving IEstimator, ITransformer ,IDataReader, IDataReaderEstimator, … #2529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…chemaShape from Microsoft.ML.Core.Data to Microsoft.ML
rogancarr
approved these changes
Feb 13, 2019
| @@ -27,7 +26,7 @@ | |||
| [assembly: LoadableClass(typeof(void), typeof(KMeansPlusPlusTrainer), null, typeof(SignatureEntryPointModule), "KMeans")] | |||
|
|
|||
| namespace Microsoft.ML.Trainers.KMeans | |||
| { | |||
| { | |||
| @@ -31,7 +30,7 @@ | |||
| [assembly: LoadableClass(typeof(void), typeof(RandomizedPcaTrainer), null, typeof(SignatureEntryPointModule), RandomizedPcaTrainer.LoadNameValue)] | |||
|
|
|||
| namespace Microsoft.ML.Trainers.PCA | |||
| { | |||
| { | |||
| @@ -32,7 +31,7 @@ | |||
| [assembly: LoadableClass(typeof(void), typeof(PrincipalComponentAnalysisTransformer), null, typeof(SignatureEntryPointModule), PrincipalComponentAnalysisTransformer.LoaderSignature)] | |||
|
|
|||
| namespace Microsoft.ML.Transforms.Projections | |||
| { | |||
| { | |||
| using Microsoft.ML.Data; | ||
| using Microsoft.ML.Internal.Calibration; | ||
| using Microsoft.ML.Trainers; | ||
| using Xunit; | ||
|
|
||
| namespace Microsoft.ML.Tests.TrainerEstimators | ||
| { | ||
| { |
| @@ -15,7 +13,7 @@ | |||
| using Xunit.Abstractions; | |||
|
|
|||
| namespace Microsoft.ML.Tests.TrainerEstimators | |||
| { | |||
| { | |||
|
@rogancarr I just noticed the indentation notes. I'll address them on the next pr... |
Codecov Report
@@ Coverage Diff @@
## master #2529 +/- ##
==========================================
- Coverage 71.25% 71.25% -0.01%
==========================================
Files 797 797
Lines 141280 141280
Branches 16115 16115
==========================================
- Hits 100675 100671 -4
- Misses 36147 36148 +1
- Partials 4458 4461 +3
|
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moving IEstimator, ITransformer, IDataReader, IDataReaderEstimator, SchemaShape from Microsoft.ML.Core.Data to Microsoft.ML.
Those were the only types in Microsoft.ML.Core.Data.
The change is mechanical, IMO you can just approve if the above sentence is not controversial.
Towards #2326.