Skip to content

typo in comment: "shoudl" changed to "should" #2666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 20, 2019

Conversation

elbruno
Copy link
Contributor

@elbruno elbruno commented Feb 20, 2019

typo in comment: shoudl changed to should

We are excited to review your PR.

So we can do the best job, please check:

  • There's a descriptive title that will make sense to other developers some time from now.
  • There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format Fixes #nnnn in your description to cause GitHub to automatically close the issue(s) when your PR is merged.
  • Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
  • You have included any necessary tests in the same PR.

typo in comment: shoudl changed to should
@codecov
Copy link

codecov bot commented Feb 20, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@a25763e). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #2666   +/-   ##
=========================================
  Coverage          ?   71.55%           
=========================================
  Files             ?      800           
  Lines             ?   141847           
  Branches          ?    16119           
=========================================
  Hits              ?   101498           
  Misses            ?    35896           
  Partials          ?     4453
Flag Coverage Δ
#Debug 71.55% <ø> (?)
#production 67.85% <ø> (?)
#test 85.73% <ø> (?)
Impacted Files Coverage Δ
...ft.ML.Tests/Scenarios/Api/Estimators/Evaluation.cs 100% <ø> (ø)

Copy link
Contributor

@TomFinley TomFinley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @elbruno !

@TomFinley TomFinley merged commit 3cdc716 into dotnet:master Feb 20, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Mar 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants