Changed Ranker to Ranking in evaluation related files. #2675
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2675 +/- ##
==========================================
+ Coverage 71.7% 71.7% +<.01%
==========================================
Files 808 808
Lines 142221 142221
Branches 16131 16131
==========================================
+ Hits 101981 101982 +1
- Misses 35799 35800 +1
+ Partials 4441 4439 -2
|
| @@ -25,7 +25,7 @@ namespace Microsoft.ML | |||
| [BestFriend] | |||
| internal delegate void SignatureMultiOutputRegressorTrainer(); | |||
| [BestFriend] | |||
| internal delegate void SignatureRankerTrainer(); | |||
| internal delegate void SignatureRankingTrainer(); | |||
There was a problem hiding this comment.
SignatureRankingTrainer [](start = 27, length = 23)
Since this is internal it is not a big deal, but note that this is incorrect. So you see how it is SignatureBinaryClassifierTrainer above? This is because the thing that does the task binary classification is a binary classifier. So this should have been retained as signature ranker trainer. What is the task? Ranking. What is the thing doing the task? A ranker.
Sort of like how things are being transformed, and the thing that does this is called a transformer. The use of different tenses, casing, and whatnot is deliberate.
Not a huge deal, but if you have to post another iteration anyway, this is what I would call a hypercorrection that should be backcorrected. #Resolved
| @@ -44,7 +44,7 @@ private static class DefaultEvaluatorTable | |||
| { MetadataUtils.Const.ScoreColumnKind.Regression, env => new RegressionMamlEvaluator(env, new RegressionMamlEvaluator.Arguments()) }, | |||
| { MetadataUtils.Const.ScoreColumnKind.MultiOutputRegression, env => new MultiOutputRegressionMamlEvaluator(env, new MultiOutputRegressionMamlEvaluator.Arguments()) }, | |||
| { MetadataUtils.Const.ScoreColumnKind.QuantileRegression, env => new QuantileRegressionMamlEvaluator(env, new QuantileRegressionMamlEvaluator.Arguments()) }, | |||
| { MetadataUtils.Const.ScoreColumnKind.Ranking, env => new RankerMamlEvaluator(env, new RankerMamlEvaluator.Arguments()) }, | |||
| { MetadataUtils.Const.ScoreColumnKind.Ranking, env => new RankingMamlEvaluator(env, new RankingMamlEvaluator.Arguments()) }, | |||
There was a problem hiding this comment.
RankingMamlEvaluator [](start = 86, length = 20)
Note that this renaming is correct. You are not evaluating a ranker, you are evaluating a ranking, so this one is good. #Resolved
There was a problem hiding this comment.
It is also you note now more consistent with its "brethren" here.
In reply to: 258754361 [](ancestors = 258754361)
| @@ -22,7 +22,7 @@ public enum TrainerKinds | |||
| { | |||
| SignatureBinaryClassifierTrainer, | |||
| SignatureMultiClassClassifierTrainer, | |||
| SignatureRankerTrainer, | |||
| SignatureRankingTrainer, | |||
There was a problem hiding this comment.
SignatureRankingTrainer [](start = 12, length = 23)
Another thing where this is I think hypercorrected. See how it is now inconsistent with everything else here? #Resolved
|
Another way we could go is change all these things into things like |
|
Sure! I am changing In reply to: 465837115 [](ancestors = 465837115) |
|
@Ivanidzo4ka, I accidentally click the re-request-review icon next to the review name above which made me lost your review approval. Can you please approve it back? Thanks! |
|
once it's gone, IT'S GONE! In reply to: 466194690 [](ancestors = 466194690) |
|
@Ivanidzo4ka and @TomFinley, thanks for the useful comments and suggestions. |
ghost
locked as resolved and limited conversation to collaborators
This PR fixes #2634
Some of the EntryPoint names got changed. Reviewers' are requested to please verify consequences of changing EntryPoint names.