Skip to content

Remove learningRate parameter from RandomForest #2691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 23, 2019

Conversation

singlis
Copy link
Member

@singlis singlis commented Feb 22, 2019

Removes the learning rate parameter from RandomForest as this parameter was not used
by the base class.

This fixes #2237

@singlis singlis self-assigned this Feb 22, 2019
Copy link
Contributor

@artidoro artidoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@codecov
Copy link

codecov bot commented Feb 22, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@412e1f9). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master    #2691   +/-   ##
=========================================
  Coverage          ?   71.58%           
=========================================
  Files             ?      805           
  Lines             ?   142025           
  Branches          ?    16130           
=========================================
  Hits              ?   101674           
  Misses            ?    35910           
  Partials          ?     4441
Flag Coverage Δ
#Debug 71.58% <100%> (?)
#production 67.87% <100%> (?)
#test 85.74% <ø> (?)
Impacted Files Coverage Δ
src/Microsoft.ML.FastTree/RandomForest.cs 100% <ø> (ø)
...rc/Microsoft.ML.FastTree/RandomForestRegression.cs 59.9% <100%> (ø)
...icrosoft.ML.FastTree/RandomForestClassification.cs 78.07% <100%> (ø)
src/Microsoft.ML.FastTree/TreeTrainersCatalog.cs 88.37% <100%> (ø)

@Ivanidzo4ka Ivanidzo4ka merged commit 44c3113 into dotnet:master Feb 23, 2019
@singlis singlis deleted the singlis/lr branch March 7, 2019 00:53
@ghost ghost locked as resolved and limited conversation to collaborators Mar 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove learningRate argument from FastForest constructor
3 participants