Skip to content

Hide delegates, model parameters constructors and other small things #2701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Ivanidzo4ka
Copy link
Contributor

@Ivanidzo4ka Ivanidzo4ka commented Feb 22, 2019

should fix #1974

@Ivanidzo4ka Ivanidzo4ka requested review from TomFinley, abgoswam and artidoro and removed request for TomFinley February 22, 2019 23:17
@codecov
Copy link

codecov bot commented Feb 23, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@b604b07). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master    #2701   +/-   ##
=========================================
  Coverage          ?   71.59%           
=========================================
  Files             ?      805           
  Lines             ?   141996           
  Branches          ?    16119           
=========================================
  Hits              ?   101655           
  Misses            ?    35905           
  Partials          ?     4436
Flag Coverage Δ
#Debug 71.59% <100%> (?)
#production 67.88% <100%> (?)
#test 85.73% <ø> (?)
Impacted Files Coverage Δ
...e/FieldAwareFactorizationMachineModelParameters.cs 74.7% <ø> (ø)
src/Microsoft.ML.FastTree/GamClassification.cs 89% <ø> (ø)
...StandardLearners/Standard/LinearModelParameters.cs 60.63% <ø> (ø)
...Standard/MultiClass/MultiClassNaiveBayesTrainer.cs 87.8% <ø> (ø)
src/Microsoft.ML.PCA/PcaTrainer.cs 79.64% <ø> (ø)
...t.ML.Data/Transforms/ValueToKeyMappingEstimator.cs 87.03% <ø> (ø)
...osoft.ML.StaticPipe/CategoricalStaticExtensions.cs 83.01% <ø> (ø)
...Microsoft.ML.Data/DataLoadSave/TransformWrapper.cs 33% <ø> (ø)
src/Microsoft.ML.FastTree/GamRegression.cs 89.09% <ø> (ø)
...LogisticRegression/MulticlassLogisticRegression.cs 67.46% <ø> (ø)
... and 1 more

@artidoro
Copy link
Contributor

artidoro commented Feb 23, 2019

public sealed class TransformWrapper : ITransformer

I can't wait for this to go away! #Resolved


Refers to: src/Microsoft.ML.Data/DataLoadSave/TransformWrapper.cs:20 in 622543c. [](commit_id = 622543c, deletion_comment = False)

@artidoro
Copy link
Contributor

        public readonly bool TextKeyValues;

You used to add doc comments in your previous PRs :`(


Refers to: src/Microsoft.ML.Data/Transforms/ValueToKeyMappingEstimator.cs:42 in 622543c. [](commit_id = 622543c, deletion_comment = False)

@Ivanidzo4ka
Copy link
Contributor Author

public sealed class TransformWrapper : ITransformer

All we need to do is untangle that mess in word bag extraction.


In reply to: 466601135 [](ancestors = 466601135)


Refers to: src/Microsoft.ML.Data/DataLoadSave/TransformWrapper.cs:20 in 622543c. [](commit_id = 622543c, deletion_comment = False)

@Ivanidzo4ka
Copy link
Contributor Author

        public readonly bool TextKeyValues;

Purpose of this PR is to hide stuff.
More we hide, less to document :D

I do want to change all this Term, MaxNumKeys property to something more appropriate, but not in this PR.


In reply to: 466601428 [](ancestors = 466601428)


Refers to: src/Microsoft.ML.Data/Transforms/ValueToKeyMappingEstimator.cs:42 in 622543c. [](commit_id = 622543c, deletion_comment = False)

/// <summary>
/// Estimator for untrained wrapped transformers.
/// </summary>
public abstract class TrivialWrapperEstimator : TrivialEstimator<TransformWrapper>
Copy link
Member

@abgoswam abgoswam Feb 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TrivialWrapperEstimator [](start = 26, length = 23)

where did this go ? #Resolved

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah i see. no usages in code :)


In reply to: 259595477 [](ancestors = 259595477)

Copy link
Contributor Author

@Ivanidzo4ka Ivanidzo4ka Feb 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To Valhalla!

Copy link
Member

@abgoswam abgoswam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Ivanidzo4ka Ivanidzo4ka merged commit f063510 into dotnet:master Feb 24, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Mar 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Internalize signature delegates in Core and Data assemblies
3 participants