-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Hide delegates, model parameters constructors and other small things #2701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide delegates, model parameters constructors and other small things #2701
Conversation
…et rid of trivial transformWrapper
Codecov Report
@@ Coverage Diff @@
## master #2701 +/- ##
=========================================
Coverage ? 71.59%
=========================================
Files ? 805
Lines ? 141996
Branches ? 16119
=========================================
Hits ? 101655
Misses ? 35905
Partials ? 4436
|
Purpose of this PR is to hide stuff. I do want to change all this In reply to: 466601428 [](ancestors = 466601428) Refers to: src/Microsoft.ML.Data/Transforms/ValueToKeyMappingEstimator.cs:42 in 622543c. [](commit_id = 622543c, deletion_comment = False) |
/// <summary> | ||
/// Estimator for untrained wrapped transformers. | ||
/// </summary> | ||
public abstract class TrivialWrapperEstimator : TrivialEstimator<TransformWrapper> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TrivialWrapperEstimator [](start = 26, length = 23)
where did this go ? #Resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To Valhalla!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should fix #1974