Skip to content

Move the builder classes in DataViewSchema #2703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 24, 2019

Conversation

eerhardt
Copy link
Member

  • Move MetadataBuilder to be DataViewSchema.Metadata.Builder.
  • Move SchemaBuilder to DataViewSchema.Builder.
  • Rename GetMetadata and GetSchema to ToMetadata and ToSchema

Working towards #2297

There are 2 tasks left before that issue can be closed.

  1. Rename 'metadata' to 'annotations' - a very large change.
  2. Remove anything from DataViewRowId that makes it seem like a number.

Copy link
Contributor

@rogancarr rogancarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚗 🎈

@codecov
Copy link

codecov bot commented Feb 23, 2019

Codecov Report

Merging #2703 into master will decrease coverage by 0.01%.
The diff coverage is 89%.

@@            Coverage Diff             @@
##           master    #2703      +/-   ##
==========================================
- Coverage   71.59%   71.58%   -0.02%     
==========================================
  Files         805      805              
  Lines      142004   142004              
  Branches    16119    16119              
==========================================
- Hits       101673   101654      -19     
- Misses      35891    35914      +23     
+ Partials     4440     4436       -4
Flag Coverage Δ
#Debug 71.58% <89%> (-0.02%) ⬇️
#production 67.87% <88.62%> (-0.02%) ⬇️
#test 85.73% <91.66%> (ø) ⬆️
Impacted Files Coverage Δ
...ata/Transforms/ValueToKeyMappingTransformerImpl.cs 81.38% <ø> (ø) ⬆️
...icrosoft.ML.Core/Data/MetadataBuilderExtensions.cs 100% <ø> (ø) ⬆️
....Data/Evaluators/MultiOutputRegressionEvaluator.cs 0.37% <0%> (ø) ⬆️
test/Microsoft.ML.Benchmarks/HashBench.cs 0% <0%> (ø) ⬆️
...osoft.ML.Data/Depricated/Instances/HeaderSchema.cs 0% <0%> (ø) ⬆️
...icrosoft.ML.Data/Evaluators/ClusteringEvaluator.cs 53.22% <0%> (ø) ⬆️
...osoft.ML.Transforms/Text/TokenizingByCharacters.cs 95.32% <100%> (ø) ⬆️
src/Microsoft.ML.FastTree/FastTree.cs 80.76% <100%> (ø) ⬆️
....ML.Data/Scorers/FeatureContributionCalculation.cs 94.39% <100%> (ø) ⬆️
....ML.Data/Evaluators/QuantileRegressionEvaluator.cs 68.66% <100%> (ø) ⬆️
... and 44 more

Copy link
Contributor

@Ivanidzo4ka Ivanidzo4ka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@eerhardt eerhardt merged commit 22844f6 into dotnet:master Feb 24, 2019
@eerhardt eerhardt deleted the IDataViewRenames branch February 24, 2019 02:20
@ghost ghost locked as resolved and limited conversation to collaborators Mar 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants