Skip to content

Fixing the project reference in the nuget packages for OnnxTransformer #2705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 23, 2019

Conversation

singlis
Copy link
Member

@singlis singlis commented Feb 23, 2019

Found while fixing dotnet#689, moved to separate commit.
@singlis singlis self-assigned this Feb 23, 2019
@singlis singlis changed the title Fixing the project reference in the nuget packages fro OnnxTransformer Fixing the project reference in the nuget packages for OnnxTransformer Feb 23, 2019
@codecov
Copy link

codecov bot commented Feb 23, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@44c3113). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #2705   +/-   ##
=========================================
  Coverage          ?   71.58%           
=========================================
  Files             ?      805           
  Lines             ?   142004           
  Branches          ?    16119           
=========================================
  Hits              ?   101651           
  Misses            ?    35916           
  Partials          ?     4437
Flag Coverage Δ
#Debug 71.58% <ø> (?)
#production 67.87% <ø> (?)
#test 85.73% <ø> (?)

Copy link
Contributor

@Ivanidzo4ka Ivanidzo4ka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking care of that!

Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find. It’s unfortunate that this doesn’t cause an error....

@eerhardt eerhardt merged commit 9fe8233 into dotnet:master Feb 23, 2019
@singlis singlis deleted the singlis/onnx-nuget branch March 7, 2019 00:53
@ghost ghost locked as resolved and limited conversation to collaborators Mar 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants