Skip to content

Rename DataView Metadata to Annotations. #2712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 26, 2019
Merged

Conversation

eerhardt
Copy link
Member

I have ensured there is no public API with the word metadata in it anymore. The only place this occurs is in the Microsoft.ML.UniversalModelFormat.Onnx namespace, which is a different type of "metadata".

There are still internal/private usages of the term "metadata", but this PR is large enough. We can fix those in a subsequent change.

Fix #1843
Fix #2297

@codecov
Copy link

codecov bot commented Feb 26, 2019

Codecov Report

Merging #2712 into master will decrease coverage by <.01%.
The diff coverage is 80.98%.

@@            Coverage Diff             @@
##           master    #2712      +/-   ##
==========================================
- Coverage   71.66%   71.66%   -0.01%     
==========================================
  Files         808      808              
  Lines      142253   142254       +1     
  Branches    16138    16138              
==========================================
- Hits       101950   101948       -2     
- Misses      35864    35866       +2     
- Partials     4439     4440       +1
Flag Coverage Δ
#Debug 71.66% <80.98%> (-0.01%) ⬇️
#production 67.91% <77.15%> (-0.01%) ⬇️
#test 85.85% <94.92%> (ø) ⬆️
Impacted Files Coverage Δ
src/Microsoft.ML.Core/Data/IHostEnvironment.cs 95.12% <ø> (ø) ⬆️
src/Microsoft.ML.Data/Transforms/TransformBase.cs 56.07% <ø> (ø) ⬆️
.../Microsoft.ML.StaticPipe/SchemaAssertionContext.cs 45.65% <ø> (ø) ⬆️
...rosoft.ML.Data/Scorers/QuantileRegressionScorer.cs 100% <ø> (ø) ⬆️
...Microsoft.ML.Transforms/OptionalColumnTransform.cs 28.16% <ø> (ø) ⬆️
...rc/Microsoft.ML.Core/EntryPoints/PredictorModel.cs 100% <ø> (ø) ⬆️
src/Microsoft.ML.StaticPipe/PipelineColumn.cs 71.05% <ø> (ø) ⬆️
....Data/Evaluators/MultiOutputRegressionEvaluator.cs 0.37% <0%> (ø) ⬆️
...ata/Transforms/ValueToKeyMappingTransformerImpl.cs 81.38% <0%> (ø) ⬆️
src/Microsoft.ML.LightGBM/LightGbmTrainerBase.cs 62% <0%> (ø) ⬆️
... and 143 more

Copy link
Contributor

@Ivanidzo4ka Ivanidzo4ka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Contributor

@TomFinley TomFinley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is quite the PR @eerhardt. Thank you for not only renaming the class, but making sure to also handle so much of the documentation (even internal documentation), parameter names, etc.

@eerhardt eerhardt merged commit d6a4b1d into dotnet:master Feb 26, 2019
@eerhardt eerhardt deleted the Annotations branch February 26, 2019 18:17
@ghost ghost locked as resolved and limited conversation to collaborators Mar 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Naming overhaul for IDataView subsystem Schema.Metadata needs a better name
3 participants