Microsoft.ML.Internal.Internallearn should be hidden/moved/renamed

[codemzs]

fixes #2714

[sfilipi]

[codecov]

Codecov Report

Merging #2740 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2740      +/-   ##
==========================================
+ Coverage   71.66%   71.66%   +<.01%     
==========================================
  Files         808      808              
  Lines      142364   142364              
  Branches    16121    16121              
==========================================
+ Hits       102024   102030       +6     
+ Misses      35901    35898       -3     
+ Partials     4439     4436       -3

Flag	Coverage Δ
#Debug	71.66% <ø> (ø)	⬆️
#production	67.91% <ø> (ø)	⬆️
#test	85.84% <ø> (ø)	⬆️

Impacted Files	Coverage Δ
...est/Microsoft.ML.Tests/FeatureContributionTests.cs	100% <ø> (ø)	⬆️
....Core.Tests/UnitTests/TestEarlyStoppingCriteria.cs	100% <ø> (ø)	⬆️
...dLearners/Standard/Online/OnlineGradientDescent.cs	91.3% <ø> (ø)	⬆️
test/Microsoft.ML.Predictor.Tests/TestIniModels.cs	100% <ø> (ø)	⬆️
...Microsoft.ML.Transforms/LearnerFeatureSelection.cs	0% <ø> (ø)	⬆️
...soft.ML.HalLearners/SymSgdClassificationTrainer.cs	74.69% <ø> (ø)	⬆️
test/Microsoft.ML.Functional.Tests/Validation.cs	100% <ø> (ø)	⬆️
...est/Microsoft.ML.StaticPipelineTesting/Training.cs	99.25% <ø> (ø)	⬆️
...soft.ML.FastTree/Training/EarlyStoppingCriteria.cs	83.2% <ø> (ø)
...rosoft.ML.Data/Transforms/ExplainabilityCatalog.cs	100% <ø> (ø)	⬆️
... and 16 more

[TomFinley]

public interface IEarlyStoppingCriterion

Probably should not be an interface. #Resolved

---

Refers to: src/Microsoft.ML.Data/Training/EarlyStoppingCriteria.cs:29 in 07eb860. [](commit_id = 07eb860, deletion_comment = False)

[singlis]

[singlis]

Looks good pending the feedback from Tom. I agree if that is only used by FastTree (which looks to be only referenced in the BoostedTreeOptions), then I would move that code to the FastTree assembly. #Resolved

[codemzs]

public interface IEarlyStoppingCriterion

Done.

---

In reply to: 467578760 [](ancestors = 467578760)

---

Refers to: src/Microsoft.ML.Data/Training/EarlyStoppingCriteria.cs:29 in 07eb860. [](commit_id = 07eb860, deletion_comment = False)

[codemzs]

thanks for reviewing. I have addressed Tom's comments.

---

In reply to: 467632167 [](ancestors = 467632167)