Skip to content

Remove IMultiStreamSource when path (type: string) exists in text loader APIs #2745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2019
Merged

Remove IMultiStreamSource when path (type: string) exists in text loader APIs #2745

merged 1 commit into from
Feb 27, 2019

Conversation

wschin
Copy link
Member

@wschin wschin commented Feb 26, 2019 •
edited
Loading

Fix bugs introduced in #2710. If string path and IMultiStreamSource dataExample are present at the same time, we drop IMultiStreamSource dataExample.

@wschin wschin added the API Issues pertaining the friendly API label Feb 26, 2019
@wschin wschin self-assigned this Feb 26, 2019
@wschin wschin changed the title Remove IMultiStreamSource when path (type: string) exists Remove IMultiStreamSource when path (type: string) exists in text loader APIs Feb 26, 2019
@wschin wschin requested a review from artidoro February 26, 2019 21:01
@codecov
Copy link

codecov bot commented Feb 26, 2019 •
edited
Loading

Codecov Report

Merging #2745 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2745      +/-   ##
==========================================
+ Coverage   71.66%   71.67%   +<.01%     
==========================================
  Files         808      808              
  Lines      142293   142291       -2     
  Branches    16120    16119       -1     
==========================================
+ Hits       101977   101980       +3     
+ Misses      35877    35874       -3     
+ Partials     4439     4437       -2
Flag Coverage Δ
#Debug 71.67% <100%> (ø) ⬆️
#production 67.92% <100%> (ø) ⬆️
#test 85.84% <ø> (+0.01%) ⬆️
Impacted Files Coverage Δ
...L.Data/DataLoadSave/Text/TextLoaderSaverCatalog.cs 100% <100%> (+3.92%) ⬆️
...soft.ML.Data/DataLoadSave/Text/TextLoaderCursor.cs 82.45% <0%> (-0.21%) ⬇️
...ML.Transforms/Text/StopWordsRemovingTransformer.cs 85.69% <0%> (+0.16%) ⬆️
...soft.ML.TestFramework/DataPipe/TestDataPipeBase.cs 74.09% <0%> (+0.32%) ⬆️

@TomFinley
Copy link
Contributor

Thank you @wschin !

TomFinley
TomFinley approved these changes Feb 27, 2019
View reviewed changes
Copy link
Contributor

@TomFinley TomFinley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @wschin

@TomFinley TomFinley merged commit ecd02a5 into dotnet:master Feb 27, 2019
@wschin wschin deleted the fix-test-loader-apis branch February 27, 2019 06:04
@ghost ghost locked as resolved and limited conversation to collaborators Mar 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@TomFinley TomFinley TomFinley approved these changes

@artidoro artidoro artidoro approved these changes

@Ivanidzo4ka Ivanidzo4ka Awaiting requested review from Ivanidzo4ka

@yaeldekel yaeldekel Awaiting requested review from yaeldekel

Assignees

@wschin wschin

Labels
API Issues pertaining the friendly API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wschin @TomFinley @artidoro