Skip to content

Replace Float with float #2754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 28, 2019
Merged

Replace Float with float #2754

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8e81cb0
Start updating Float to float
jwood803 Feb 27, 2019
fdcfe2f
Remove more Floats
jwood803 Feb 27, 2019
971bf32
Remove Float from files
jwood803 Feb 27, 2019
5573595
Remove Float from more files
jwood803 Feb 27, 2019
5183c1d
Change other Floats to floats
jwood803 Feb 27, 2019
ee25f14
Fix PR commens
jwood803 Feb 27, 2019
5402943
Merge branch 'master' into remove-float
jwood803 Feb 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/Microsoft.ML.Core/Utilities/BinFinder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

using System;
using System.Collections.Generic;
using Float = System.Single;

namespace Microsoft.ML.Internal.Utilities
{
Expand Down Expand Up @@ -318,7 +317,7 @@ public Peg(int index, int split)
private HeapNode.Heap<Peg> _pegHeap; // heap used for selecting the largest energy decrease
private int[] _accum; // integral of counts
private int[] _path; // current set of pegs
private Float _meanBinSize;
private float _meanBinSize;

public GreedyBinFinder()
{
Expand All @@ -338,7 +337,7 @@ protected override void FindBinsCore(List<int> counts, int[] path)
_accum = new int[CountValues + 1];
for (int i = 0; i < CountValues; i++)
_accum[i + 1] = _accum[i] + counts[i];
_meanBinSize = (Float)_accum[CountValues] / CountBins;
_meanBinSize = (float)_accum[CountValues] / CountBins;

PlacePegs();

Expand Down
Loading