Cleaned and fixed public API surface for KMeans, NaiveBayes, OLS. #2819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeahmed
changed the title
|
Small comments, otherwise looks super good! #Resolved |
Codecov Report
@@ Coverage Diff @@
## master #2819 +/- ##
==========================================
+ Coverage 71.68% 71.69% +0.01%
==========================================
Files 808 809 +1
Lines 142402 142494 +92
Branches 16113 16114 +1
==========================================
+ Hits 102076 102162 +86
- Misses 35893 35900 +7
+ Partials 4433 4432 -1
|
sfilipi
reviewed
Mar 4, 2019
| @@ -9,7 +9,7 @@ public static void Example() | |||
| { | |||
| // Create a new ML context, for ML.NET operations. It can be used for exception tracking and logging, | |||
| // as well as the source of randomness. | |||
| var ml = new MLContext(); | |||
| var ml = new MLContext(seed: 1, conc: 1); | |||
There was a problem hiding this comment.
seed: 1, conc: 1 [](start = 35, length = 16)
is this needed? #Resolved
There was a problem hiding this comment.
Yes, its needed otherwise results are different on every run.
In reply to: 262274167 [](ancestors = 262274167)
Please link to the KMeansPlusPlusTrainerthrough Shahab put a template in place for how to document extensions, so we have a pointer to the main estimator where there are more explanations. Refers to: src/Microsoft.ML.KMeansClustering/KMeansCatalog.cs:19 in 2a1bb29. [](commit_id = 2a1bb29, deletion_comment = False) |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the final PR related to #2620. This PR finally fixes #2620
The following learners are addressed in this PR.
the following tasks were performed in classes related to above learners.
Checking to make sure that unnecessary public methods/properties be internal.
Renaming parameters according to standard.
Creating/Refactoring samples according to standards.