Skip to content

Scrubbing feature selection #2852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 5, 2019
Merged

Scrubbing feature selection #2852

merged 1 commit into from
Mar 5, 2019

Conversation

Ivanidzo4ka
Copy link
Contributor

fixes #2830

@Ivanidzo4ka Ivanidzo4ka changed the title First iteration Scrubbing feature selection Mar 5, 2019
@codecov
Copy link

codecov bot commented Mar 5, 2019 •
edited
Loading

Codecov Report

Merging #2852 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2852      +/-   ##
==========================================
- Coverage   71.71%    71.7%   -0.02%     
==========================================
  Files         809      809              
  Lines      142550   142551       +1     
  Branches    16114    16114              
==========================================
- Hits       102231   102214      -17     
- Misses      35885    35908      +23     
+ Partials     4434     4429       -5
Flag Coverage Δ
#Debug 71.7% <100%> (-0.02%) ⬇️
#production 67.93% <100%> (-0.02%) ⬇️
#test 85.9% <100%> (ø) ⬆️
Impacted Files Coverage Δ
...Microsoft.ML.Transforms/FeatureSelectionCatalog.cs 100% <100%> (ø) ⬆️
...oft.ML.Tests/Transformers/FeatureSelectionTests.cs 100% <100%> (ø) ⬆️
...ML.Transforms/MutualInformationFeatureSelection.cs 78.36% <100%> (ø) ⬆️
...c/Microsoft.ML.Transforms/CountFeatureSelection.cs 92.92% <100%> (+0.03%) ⬆️
src/Microsoft.ML.Core/Data/ProgressReporter.cs 70.95% <0%> (-6.99%) ⬇️
...ML.Transforms/Text/StopWordsRemovingTransformer.cs 85.69% <0%> (+0.16%) ⬆️

artidoro
artidoro approved these changes Mar 5, 2019
View reviewed changes
Copy link
Contributor

@artidoro artidoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

rogancarr
rogancarr approved these changes Mar 5, 2019
View reviewed changes
Copy link
Contributor

@rogancarr rogancarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎈

@Ivanidzo4ka Ivanidzo4ka merged commit 61aa540 into dotnet:master Mar 5, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Mar 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@artidoro artidoro artidoro approved these changes

@rogancarr rogancarr rogancarr approved these changes

@yaeldekel yaeldekel Awaiting requested review from yaeldekel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scrubbing feature selection transformers
3 participants
@Ivanidzo4ka @artidoro @rogancarr