Skip to content

Specify MaxNumberOfIterations for SDCA, K-Means #2883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 8, 2019
Merged

Specify MaxNumberOfIterations for SDCA, K-Means #2883

merged 2 commits into from
Mar 8, 2019

Conversation

rogancarr
Copy link
Contributor

This PR updates SDCA and K-Means to specify MaximumNumberOfIterations rather than NumberOfIterations to make the name more precise. Essentially, for these learners, the maximum number of iterations is a worst-case scenario and a last-resort stopping criteria.

Fixes #2871

@rogancarr rogancarr requested a review from artidoro March 7, 2019 20:39
@rogancarr
Copy link
Contributor Author

Also saw a place where we forgot to put NumberOfClusters for K-Means, so fixing this there too.

@rogancarr rogancarr requested a review from Ivanidzo4ka March 7, 2019 20:48
artidoro
artidoro approved these changes Mar 7, 2019
View reviewed changes
Copy link
Contributor

@artidoro artidoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@rogancarr rogancarr requested a review from sfilipi March 7, 2019 23:18
Ivanidzo4ka
Ivanidzo4ka approved these changes Mar 8, 2019
View reviewed changes
Copy link
Contributor

@Ivanidzo4ka Ivanidzo4ka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Ivanidzo4ka Ivanidzo4ka merged commit ee0d1d5 into dotnet:master Mar 8, 2019
@rogancarr rogancarr deleted the 2871_max_iterations branch March 8, 2019 21:13
@rogancarr rogancarr mentioned this pull request Mar 12, 2019
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Mar 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Ivanidzo4ka Ivanidzo4ka Ivanidzo4ka approved these changes

@artidoro artidoro artidoro approved these changes

@sfilipi sfilipi Awaiting requested review from sfilipi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rogancarr @Ivanidzo4ka @artidoro