Skip to content

TrainTestSplit should be inside MLContext.Data #2905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

TrainTestSplit should be inside MLContext.Data #2905

wants to merge 7 commits into from

Conversation

ganik
Copy link
Member

@ganik ganik commented Mar 11, 2019

fixes #2337

@artidoro
Copy link
Contributor

// The .NET Foundation licenses this file to you under the MIT license.

Could you update the MlNetCookBook.md for both dynamic and static?


Refers to: test/Microsoft.ML.Tests/Scenarios/Api/CookbookSamples/CookbookSamples.cs:2 in c1be3c8. [](commit_id = c1be3c8, deletion_comment = False)

@codecov
Copy link

codecov bot commented Mar 11, 2019

Codecov Report

Merging #2905 into master will increase coverage by <.01%.
The diff coverage is 94.33%.

@@            Coverage Diff             @@
##           master    #2905      +/-   ##
==========================================
+ Coverage    71.8%   71.81%   +<.01%     
==========================================
  Files         812      812              
  Lines      142644   142643       -1     
  Branches    16090    16090              
==========================================
+ Hits       102432   102436       +4     
+ Misses      35828    35824       -4     
+ Partials     4384     4383       -1
Flag Coverage Δ
#Debug 71.81% <94.33%> (ø) ⬆️
#production 67.95% <93.61%> (ø) ⬆️
#test 86.25% <100%> (ø) ⬆️
Impacted Files Coverage Δ
src/Microsoft.ML.Data/TrainCatalog.cs 84.11% <ø> (-1.72%) ⬇️
...icrosoft.ML.StaticPipe/TrainingStaticExtensions.cs 27.92% <ø> (ø) ⬆️
...rosoft.ML.StaticPipelineTesting/StaticPipeTests.cs 95.27% <ø> (-0.01%) ⬇️
test/Microsoft.ML.Functional.Tests/Prediction.cs 100% <100%> (ø) ⬆️
test/Microsoft.ML.Functional.Tests/Validation.cs 100% <100%> (ø) ⬆️
...s/Scenarios/Api/CookbookSamples/CookbookSamples.cs 99.49% <100%> (ø) ⬆️
...est/Microsoft.ML.StaticPipelineTesting/Training.cs 99.37% <100%> (ø) ⬆️
...s/Api/CookbookSamples/CookbookSamplesDynamicApi.cs 93.62% <100%> (ø) ⬆️
test/Microsoft.ML.Tests/Scenarios/Api/TestApi.cs 97.6% <100%> (ø) ⬆️
...soft.ML.Data/DataLoadSave/DataOperationsCatalog.cs 72.26% <93.61%> (+11.15%) ⬆️
... and 4 more

Copy link
Contributor

@artidoro artidoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! And the fact that the it used to be in the base training catalog makes me thing this was a good change. Please make sure to update the cookbooks before checking in.

@ganik ganik closed this Mar 11, 2019
@ganik ganik deleted the ganik/tt branch March 11, 2019 18:43
@ghost ghost locked as resolved and limited conversation to collaborators Mar 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TrainTestSplit should be inside MLContext.Data
2 participants