Scrub text featurizers #2944
Merged
Scrub text featurizers #2944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
Codecov Report
@@ Coverage Diff @@
## master #2944 +/- ##
==========================================
- Coverage 72.19% 72.18% -0.01%
==========================================
Files 796 796
Lines 142023 142023
Branches 16046 16046
==========================================
- Hits 102527 102521 -6
- Misses 35116 35121 +5
- Partials 4380 4381 +1
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #2944 +/- ##
==========================================
- Coverage 72.19% 72.18% -0.01%
==========================================
Files 796 796
Lines 142023 142023
Branches 16046 16046
==========================================
- Hits 102527 102521 -6
- Misses 35116 35121 +5
- Partials 4380 4381 +1
|
abgoswam
reviewed
Mar 13, 2019
| [Argument(ArgumentType.AtMostOnce, HelpText = "Casing text using the rules of the invariant culture.", ShortName = "case", SortOrder = 5)] | ||
| public CaseMode TextCase = TextNormalizingEstimator.Defaults.Mode; | ||
| [Argument(ArgumentType.AtMostOnce, HelpText = "Casing text using the rules of the invariant culture.", Name="TextCase", ShortName = "case", SortOrder = 5)] | ||
| public CaseMode CaseMode = TextNormalizingEstimator.Defaults.Mode; |
There was a problem hiding this comment.
CaseMode [](start = 28, length = 8)
does it make sense to call it TextCaseMode ? #WontFix
There was a problem hiding this comment.
This is CaseMode in TextFeaturizingEstimator, I'd say Text will look a bit redundant.
In reply to: 265302608 [](ancestors = 265302608)
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last step of #2832.