Get rid of public tuples #2950
Get rid of public tuples #2950
Conversation
| /// <summary> | ||
| /// Drops missing values from columns. | ||
| /// </summary> | ||
| public sealed class MissingValueDroppingEstimator : TrivialEstimator<MissingValueDroppingTransformer> |
There was a problem hiding this comment.
Don't we need this estimator anymore? Is there any alternative? #Closed
There was a problem hiding this comment.
We don't have extensions for this estimator.
We use transformer as part of other transformers, but I don't see any work with estimator.
I'm tempted to make transformer internal as well, since I don't see how it can be useful for user...
In reply to: 265372049 [](ancestors = 265372049)
There was a problem hiding this comment.
Unless we have a scenario I would certainly welcome internalizing it, since we can always de-internalize it once we do have a scenario. But if we view this as too far then I'd understand that as well.
Codecov Report
@@ Coverage Diff @@
## master #2950 +/- ##
==========================================
+ Coverage 72.19% 72.26% +0.06%
==========================================
Files 796 796
Lines 142038 142287 +249
Branches 16047 16042 -5
==========================================
+ Hits 102548 102824 +276
+ Misses 35110 35086 -24
+ Partials 4380 4377 -3
|
| @@ -20,8 +20,8 @@ public sealed class LatentDirichletAllocationFitResult | |||
| /// <param name="result"></param> | |||
| public delegate void OnFit(LatentDirichletAllocationFitResult result); | |||
|
|
|||
| public LatentDirichletAllocationTransformer.LdaSummary LdaTopicSummary; | |||
| public LatentDirichletAllocationFitResult(LatentDirichletAllocationTransformer.LdaSummary ldaTopicSummary) | |||
| public LatentDirichletAllocationTransformer.LdaModelParameters LdaTopicSummary; | |||
There was a problem hiding this comment.
LdaModelParameters [](start = 52, length = 18)
Since the model parameters is an internal class, why not call it ModelParameters instead of LdaModelParameters?
ghost
locked as resolved and limited conversation to collaborators
fixes #2881