Skip to content

Enable MyGet uploads again #2961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 15, 2019
Merged

Enable MyGet uploads again #2961

merged 1 commit into from
Mar 15, 2019

Conversation

shauheen
Copy link
Contributor

#2240 required to disable the upload. Seems the issue is fixed now.

Unverified

No user is associated with the committer email.
@codecov
Copy link

codecov bot commented Mar 14, 2019

Codecov Report

Merging #2961 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2961      +/-   ##
==========================================
- Coverage   72.29%   72.28%   -0.01%     
==========================================
  Files         796      796              
  Lines      142349   142349              
  Branches    16051    16051              
==========================================
- Hits       102905   102902       -3     
- Misses      35063    35066       +3     
  Partials     4381     4381
Flag Coverage Δ
#Debug 72.28% <ø> (-0.01%) ⬇️
#production 68% <ø> (-0.01%) ⬇️
#test 88.48% <ø> (ø) ⬆️
Impacted Files Coverage Δ
src/Microsoft.ML.Transforms/Text/LdaTransform.cs 89.26% <0%> (-0.63%) ⬇️
...ML.Transforms/Text/StopWordsRemovingTransformer.cs 85.69% <0%> (+0.16%) ⬆️

Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/dotnet/core-eng/issues/5070 is still open. And @mmitche said he hasn't heard anything back from myget on the status.

I assume we will see official build errors once this goes in, but if you want to enable it again, I won't block you.

@Ivanidzo4ka Ivanidzo4ka merged commit 8ad83d8 into dotnet:master Mar 15, 2019
@shauheen
Copy link
Contributor Author

@eerhardt , I spoke with @safern and he suggested that other repos don't seem to have this issue anymore. If it breaks again will take it out, but we haven't pushed to MyGet in almost a week.

@shauheen shauheen deleted the feature/enable_myget branch March 15, 2019 18:53
@ghost ghost locked as resolved and limited conversation to collaborators Mar 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants