Skip to content

Include the save file action (.ZIP file) as part of model.SaveFile(). #2993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 19, 2019
Merged

Include the save file action (.ZIP file) as part of model.SaveFile(). #2993

merged 3 commits into from
Mar 19, 2019

Conversation

codemzs
Copy link
Member

@codemzs codemzs commented Mar 18, 2019

fixes #1689

@codecov
Copy link

codecov bot commented Mar 18, 2019 •
edited by codemzs
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@02524a7). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master    #2993   +/-   ##
=========================================
  Coverage          ?   72.28%           
=========================================
  Files             ?      796           
  Lines             ?   142352           
  Branches          ?    16051           
=========================================
  Hits              ?   102893           
  Misses            ?    35075           
  Partials          ?     4384
Flag Coverage Δ
#Debug 72.28% <100%> (?)
#production 67.99% <100%> (?)
#test 88.48% <100%> (?)
Impacted Files Coverage Δ
.../Microsoft.ML.Data/Model/ModelOperationsCatalog.cs 100% <100%> (ø)
...soft.ML.TestFramework/DataPipe/TestDataPipeBase.cs 73.64% <100%> (ø)
#Resolved

eerhardt
eerhardt approved these changes Mar 18, 2019
View reviewed changes
TomFinley
TomFinley suggested changes Mar 18, 2019
View reviewed changes
Copy link
Contributor

@TomFinley TomFinley left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @codemzs , thanks for looking at this. This appears to not be consistent with our discussion and thinking in #2858. Could you comment on this? ccing @yaeldekel

codemzs
codemzs commented Mar 19, 2019
View reviewed changes
TomFinley
TomFinley approved these changes Mar 19, 2019
View reviewed changes
Copy link
Contributor

@TomFinley TomFinley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you for adjusting it @codemzs !!

@codemzs codemzs merged commit 8ed72fb into dotnet:master Mar 19, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Sep 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eerhardt eerhardt eerhardt approved these changes

@CESARDELATORRE CESARDELATORRE Awaiting requested review from CESARDELATORRE

@sfilipi sfilipi Awaiting requested review from sfilipi

+1 more reviewer

@TomFinley TomFinley TomFinley approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Include the "save file" action (.ZIP file) as part of model.SaveFile()
3 participants
@codemzs @eerhardt @TomFinley