Added tests for text featurizer options (Part1). #3006
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3006 +/- ##
==========================================
+ Coverage 72.39% 72.45% +0.06%
==========================================
Files 803 803
Lines 143590 143837 +247
Branches 16164 16173 +9
==========================================
+ Hits 103946 104222 +276
+ Misses 35225 35199 -26
+ Partials 4419 4416 -3
|
Ivanidzo4ka
reviewed
Mar 19, 2019
| new TestClass() { A = "No stop words", OutputText=null } }; | ||
| var dataView = ML.Data.LoadFromEnumerable(data); | ||
|
|
||
| var options = new TextFeaturizingEstimator.Options() { StopWordsRemoverOptions = new StopWordsRemovingEstimator.Options(), OutputTokens = true }; |
There was a problem hiding this comment.
OutputTokens [](start = 135, length = 12)
You need to merge master in your code. #Resolved
Ivanidzo4ka
reviewed
Mar 19, 2019
| private class TestClass | ||
| { | ||
| public string A; | ||
| [ColumnName("OutputText_TransformedText")] |
There was a problem hiding this comment.
OutputText_TransformedText [](start = 25, length = 26)
You can give it name without _ after merge with master. #Resolved
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR partially address #2967. See the following list. Further tests will be added in the next PR.
Test created for following parameters in options class