Updating the FunctionalTests to clearly explain why they are not strong named signed. #3010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3010 +/- ##
=========================================
Coverage ? 72.35%
=========================================
Files ? 803
Lines ? 143290
Branches ? 16155
=========================================
Hits ? 103673
Misses ? 35191
Partials ? 4426
|
Ivanidzo4ka
approved these changes
Mar 19, 2019
rogancarr
reviewed
Mar 19, 2019
| @@ -1,8 +1,9 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
|
|
|||
| <PropertyGroup> | |||
| <!-- We are turning off strong naming to ensure we never add `InternalsVisibleTo` for these tests --> | |||
| <SignAssembly>true</SignAssembly> | |||
| <!-- DON'T CHANGE THIS!!! We are turning off strong naming to ensure we never add `InternalsVisibleTo` for these tests --> | |||
There was a problem hiding this comment.
!!! [](start = 26, length = 3)
!!!
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2858 (comment) for an example of why this is necessary.