Fix bug in TextLoader #3056
Merged
Fix bug in TextLoader #3056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaeldekel
commented
Mar 21, 2019
| if (info.Type != typeof(ILegacyDataLoader) || info.ArgType != typeof(Options)) | ||
| // Make sure that the schema is described using either the syntax TextLoader{<settings>} or the syntax Text{<settings>}, | ||
| // where "settings" is a string that can be parsed by CmdParser into an object of type TextLoader.Options. | ||
| if (loader == null || string.IsNullOrWhiteSpace(loader.Name) || (loader.Name != LoaderSignature && loader.Name != "Text")) |
There was a problem hiding this comment.
Name [](start = 88, length = 4)
The previous check was to verify that loader.Name is one of the names defined in TextLoader's LoadableClassAttribute. Since now we cannot rely on this attribute being in the ComponentCatalog, we explicitly require loader.Name to be one of the load names of TextLoader.
TomFinley
approved these changes
Mar 22, 2019
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2996. (This PR replaces #3011).