Fixing API call in LoadImages sample #3084
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaeldekel
reviewed
Mar 25, 2019
| @@ -36,7 +36,7 @@ public static void Example() | |||
|
|
|||
| var imagesFolder = Path.GetDirectoryName(imagesDataFile); | |||
| // Image loading pipeline. | |||
| var pipeline = mlContext.Transforms.LoadImages(imagesFolder, "ImageReal", "ImagePath"); | |||
| var pipeline = mlContext.Transforms.LoadImages("ImageReal", imagesFolder, "ImagePath"); | |||
There was a problem hiding this comment.
LoadImages [](start = 48, length = 10)
Hi @rogancarr, thanks for addressing this issue.
Sorry, I should have been more specific in the issue itself - there are a few more references to this API in the samples project (DnnFeaturizeImage, ResizeImage, ConvertToGrayScale, ExtractPixels), could you update these as well?
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
LoadImagessample had the wrong API call. This PR fixes it so that the sample runs correctly.Fixes #3079