-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Remove generic normalizer estimator catalog methods. #3116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3116 +/- ##
==========================================
- Coverage 72.53% 72.53% -0.01%
==========================================
Files 808 808
Lines 144740 144734 -6
Branches 16202 16201 -1
==========================================
- Hits 104987 104979 -8
- Misses 35343 35344 +1
- Partials 4410 4411 +1
|
b660139
to
0c283e0
Compare
using Microsoft.ML.Data; | ||
using Microsoft.ML.Transforms; | ||
using Microsoft.ML.Experimental; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it just experimental? We are removing the generic estimator, so these new methods must be supported officially and therefore deserve a namespace like ML.Transform
. Is my understanding correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixes #3161