Pass weighting value from ProduceWordBags to WordBagEstimator constru… #3135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3135 +/- ##
==========================================
- Coverage 72.52% 72.52% -0.01%
==========================================
Files 808 808
Lines 144665 144665
Branches 16198 16198
==========================================
- Hits 104914 104912 -2
- Misses 35340 35343 +3
+ Partials 4411 4410 -1
|
Ivanidzo4ka
reviewed
Mar 28, 2019
| @@ -283,7 +283,7 @@ public static class TextCatalog | |||
| int maximumNgramsCount = NgramExtractingEstimator.Defaults.MaximumNgramsCount, | |||
| NgramExtractingEstimator.WeightingCriteria weighting = NgramExtractingEstimator.WeightingCriteria.Tf) | |||
| => new WordBagEstimator(Contracts.CheckRef(catalog, nameof(catalog)).GetEnvironment(), | |||
| outputColumnName, inputColumnName, ngramLength, skipLength, useAllLengths, maximumNgramsCount); | |||
| outputColumnName, inputColumnName, ngramLength, skipLength, useAllLengths, maximumNgramsCount, weighting); | |||
There was a problem hiding this comment.
weighting [](start = 111, length = 9)
Would be nice to add baseline test, something similar to TestWordEmbeddings.
Thank you for catching and fixing it!
zeahmed
approved these changes
Mar 28, 2019
shauheen
pushed a commit
to shauheen/machinelearning
that referenced
this pull request
Apr 2, 2019
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3134