-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Put product version with git commit into model.zip/version.txt #3173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Put product version with git commit into model.zip/version.txt #3173
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3173 +/- ##
==========================================
- Coverage 72.54% 72.54% -0.01%
==========================================
Files 807 807
Lines 144774 144775 +1
Branches 16208 16208
==========================================
- Hits 105022 105021 -1
- Misses 35338 35340 +2
Partials 4414 4414
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Do we want to take this for 1.0
?
Well, in 1.0 version file would have 1.0.0.0 version in it, so I don't think it's super critical. For 1.1 or whatever future branch would be ,it would have this change, so, i'm not sure it's worth 1.0. |
If/when we service the |
Fixes #3132