Fix IncludeBuildNumberInPackageVersion for official builds #3182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When doing an official build and setting a AzDO build variable, the variable turns into an environment variable. When MSBuild props/targets files declare a property, if they don't check if the property is already set, the MSBuild props file will override the environment variable. This causes the AzDO build variable to be ignored. Adding a check if the IncludeBuildNumberInPackageVersion property is already set before setting it in Directory.Build.props.
safern
approved these changes
Apr 2, 2019
Codecov Report
@@ Coverage Diff @@
## master #3182 +/- ##
==========================================
- Coverage 72.54% 72.53% -0.01%
==========================================
Files 807 807
Lines 144774 144774
Branches 16208 16208
==========================================
- Hits 105021 105011 -10
- Misses 35339 35347 +8
- Partials 4414 4416 +2
|
codemzs
approved these changes
Apr 2, 2019
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing an official build and setting a AzDO build variable, the variable turns into an environment variable. When MSBuild props/targets files declare a property, if they don't check if the property is already set, the MSBuild props file will override the environment variable. This causes the AzDO build variable to be ignored.
Adding a check if the IncludeBuildNumberInPackageVersion property is already set before setting it in Directory.Build.props.
This is a cherry-pick of #3181 for the
masterbranch.