Skip to content

TimeSeriesStatics naming. #3215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 5, 2019
Merged

TimeSeriesStatics naming. #3215

merged 1 commit into from
Apr 5, 2019

Conversation

codemzs
Copy link
Member

@codemzs codemzs commented Apr 5, 2019

fixes #3203

@codemzs codemzs requested review from wschin and shmoradims April 5, 2019 09:17
@codecov
Copy link

codecov bot commented Apr 5, 2019

Codecov Report

Merging #3215 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3215      +/-   ##
==========================================
+ Coverage    72.6%    72.6%   +<.01%     
==========================================
  Files         807      807              
  Lines      145077   145077              
  Branches    16213    16213              
==========================================
+ Hits       105337   105338       +1     
+ Misses      35322    35321       -1     
  Partials     4418     4418
Flag Coverage Δ
#Debug 72.6% <ø> (ø) ⬆️
#production 68.15% <ø> (ø) ⬆️
#test 88.92% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...osoft.ML.TimeSeries.StaticPipe/TimeSeriesStatic.cs 100% <ø> (ø) ⬆️
src/Microsoft.ML.Maml/MAML.cs 24.75% <0%> (-1.46%) ⬇️
...soft.ML.Transforms/Text/WordEmbeddingsExtractor.cs 86.39% <0%> (-1.14%) ⬇️
...ML.Transforms/Text/StopWordsRemovingTransformer.cs 86.26% <0%> (+0.15%) ⬆️
...c/Microsoft.ML.FastTree/Utils/ThreadTaskManager.cs 100% <0%> (+20.51%) ⬆️

1 similar comment
@codecov
Copy link

codecov bot commented Apr 5, 2019

Codecov Report

Merging #3215 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3215      +/-   ##
==========================================
+ Coverage    72.6%    72.6%   +<.01%     
==========================================
  Files         807      807              
  Lines      145077   145077              
  Branches    16213    16213              
==========================================
+ Hits       105337   105338       +1     
+ Misses      35322    35321       -1     
  Partials     4418     4418
Flag Coverage Δ
#Debug 72.6% <ø> (ø) ⬆️
#production 68.15% <ø> (ø) ⬆️
#test 88.92% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...osoft.ML.TimeSeries.StaticPipe/TimeSeriesStatic.cs 100% <ø> (ø) ⬆️
src/Microsoft.ML.Maml/MAML.cs 24.75% <0%> (-1.46%) ⬇️
...soft.ML.Transforms/Text/WordEmbeddingsExtractor.cs 86.39% <0%> (-1.14%) ⬇️
...ML.Transforms/Text/StopWordsRemovingTransformer.cs 86.26% <0%> (+0.15%) ⬆️
...c/Microsoft.ML.FastTree/Utils/ThreadTaskManager.cs 100% <0%> (+20.51%) ⬆️

@Ivanidzo4ka
Copy link
Contributor

How exactly this change FIXES #3203 which claims we have issue with nuget dependency?

@codemzs
Copy link
Member Author

codemzs commented Apr 5, 2019

@Ivanidzo4ka It fixes the naming part of the issue.

@codemzs codemzs merged commit b291d95 into dotnet:master Apr 5, 2019
codemzs added a commit to codemzs/machinelearning that referenced this pull request Apr 11, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Mar 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extension methods from TimeSeriesStatic.cs (A Typo and A Missing Nuget for Static Time Series)
4 participants