Skip to content

Polish marshalling of MF model and MF problem and enable 32-bit tests #3227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 8, 2019
Merged

Polish marshalling of MF model and MF problem and enable 32-bit tests #3227

merged 3 commits into from
Apr 8, 2019

Conversation

wschin
Copy link
Member

@wschin wschin commented Apr 5, 2019

Fix #1441. Also related to some suggestion made in #3210.

@wschin wschin added the bug Something isn't working label Apr 5, 2019
@wschin wschin self-assigned this Apr 5, 2019
@wschin wschin requested review from eerhardt and TomFinley April 5, 2019 23:30
@wschin
Polish marshalling of MF model and MF problem and enable 32-bit tests
39ec752 
Reset pointer after deleting it

Consistency of declaring types in bridge classes

More explicit-size types
@wschin wschin requested a review from artidoro April 6, 2019 00:02
@codecov
Copy link

codecov bot commented Apr 6, 2019 •
edited
Loading

Codecov Report

Merging #3227 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3227      +/-   ##
==========================================
- Coverage   72.62%   72.61%   -0.01%     
==========================================
  Files         807      807              
  Lines      145080   145080              
  Branches    16213    16213              
==========================================
- Hits       105366   105357       -9     
- Misses      35297    35304       +7     
- Partials     4417     4419       +2
Flag Coverage Δ
#Debug 72.61% <100%> (-0.01%) ⬇️
#production 68.16% <ø> (-0.01%) ⬇️
#test 88.92% <100%> (ø) ⬆️
Impacted Files Coverage Δ
...osoft.ML.Recommender/SafeTrainingAndModelBuffer.cs 78.87% <ø> (ø) ⬆️
...ork/Attributes/MatrixFactorizationFactAttribute.cs 100% <100%> (ø) ⬆️
...c/Microsoft.ML.FastTree/Utils/ThreadTaskManager.cs 79.48% <0%> (-20.52%) ⬇️
...ML.Transforms/Text/StopWordsRemovingTransformer.cs 86.1% <0%> (-0.16%) ⬇️
...ML.Data/Transforms/ConversionsExtensionsCatalog.cs 64.07% <0%> (ø) ⬆️

eerhardt
eerhardt approved these changes Apr 6, 2019
View reviewed changes
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

shauheen
shauheen approved these changes Apr 8, 2019
View reviewed changes
Copy link
Contributor

@shauheen shauheen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@wschin wschin merged commit fdd24cf into dotnet:master Apr 8, 2019
@wschin wschin deleted the marshal-mf branch April 8, 2019 17:48
wschin added a commit to wschin/machinelearning that referenced this pull request Apr 11, 2019
@wschin
Polish marshalling of MF model and MF problem and enable 32-bit tests (…
fb0b69c 
…dotnet#3227)
@wschin wschin mentioned this pull request Apr 11, 2019
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Mar 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eerhardt eerhardt eerhardt approved these changes

@shauheen shauheen shauheen approved these changes

@TomFinley TomFinley Awaiting requested review from TomFinley

@artidoro artidoro Awaiting requested review from artidoro

Assignees

@wschin wschin

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wschin @shauheen @eerhardt