Skip to content

Using named-tuple in OneToOneTransforms' constructor to make API more readable. #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jun 12, 2018
Merged

Using named-tuple in OneToOneTransforms' constructor to make API more readable. #324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
21d2b48
Merge pull request #1 from dotnet/master
zeahmed May 23, 2018
405ffcf
Merge remote-tracking branch 'upstream/master'
zeahmed May 24, 2018
966b091
Merge remote-tracking branch 'upstream/master'
zeahmed May 29, 2018
0a8ec57
Merge remote-tracking branch 'upstream/master'
zeahmed May 30, 2018
a5e9a1d
Merge remote-tracking branch 'upstream/master'
zeahmed Jun 4, 2018
37959d0
Merge remote-tracking branch 'upstream/master'
zeahmed Jun 6, 2018
8f556a2
Using named-tuple in OneToOneTransforms' constructor to make API more…
zeahmed Jun 7, 2018
a1e7f4e
merged upstream/master
zeahmed Jun 10, 2018
ea0e043
Removed merged conflicts.
zeahmed Jun 11, 2018
8ff61dd
merged master
zeahmed Jun 12, 2018
d0c57c6
Resolved merge conflicts.
zeahmed Jun 12, 2018
47594dc
A few formatting changes.
zeahmed Jun 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Microsoft.ML.Data/Model/Onnx/OnnxContext.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public sealed class OnnxContext
private readonly string _producerVersion;
private readonly long _modelVersion;

public OnnxContext(IHostEnvironment env, string name, string producerName,
public OnnxContext(IHostEnvironment env, string name, string producerName,
string producerVersion, long modelVersion, string domain)
{
Contracts.CheckValue(env, nameof(env));
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.ML.Data/Model/Onnx/OnnxUtils.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,7 @@ public NodeProtoWrapper(NodeProto node)
}
}

public static ModelProto MakeModel(List<NodeProto> nodes, string producerName, string name,
public static ModelProto MakeModel(List<NodeProto> nodes, string producerName, string name,
string domain, string producerVersion, long modelVersion, List<ModelArgs> inputs,
List<ModelArgs> outputs, List<ModelArgs> intermediateValues)
{
Expand Down
Loading