Skip to content

Ensable the uses of SSE and OpenMP in LIBMF #3265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 10, 2019

Conversation

wschin
Copy link
Member

@wschin wschin commented Apr 9, 2019

Fix #1408 by compiling LIBMF with SSE and OpenMP.

@wschin wschin self-assigned this Apr 9, 2019
@codecov
Copy link

codecov bot commented Apr 9, 2019

Codecov Report

Merging #3265 into master will decrease coverage by <.01%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master    #3265      +/-   ##
==========================================
- Coverage   72.62%   72.62%   -0.01%     
==========================================
  Files         807      807              
  Lines      145080   145080              
  Branches    16213    16213              
==========================================
- Hits       105370   105360      -10     
- Misses      35294    35302       +8     
- Partials     4416     4418       +2
Flag Coverage Δ
#Debug 72.62% <83.33%> (-0.01%) ⬇️
#production 68.17% <ø> (-0.01%) ⬇️
#test 88.92% <83.33%> (ø) ⬆️
Impacted Files Coverage Δ
...ests/TrainerEstimators/MatrixFactorizationTests.cs 96.92% <83.33%> (ø) ⬆️
...c/Microsoft.ML.FastTree/Utils/ThreadTaskManager.cs 79.48% <0%> (-20.52%) ⬇️
...soft.ML.Data/DataLoadSave/Text/TextLoaderCursor.cs 84.7% <0%> (-0.21%) ⬇️
...ML.Transforms/Text/StopWordsRemovingTransformer.cs 86.1% <0%> (-0.16%) ⬇️
src/Microsoft.ML.Transforms/ConversionsCatalog.cs 83.33% <0%> (ø) ⬆️
...ML.Data/Transforms/ConversionsExtensionsCatalog.cs 64.07% <0%> (ø) ⬆️
src/Microsoft.ML.Data/Data/SchemaDefinition.cs 69.87% <0%> (ø) ⬆️

Copy link
Member

@codemzs codemzs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@wschin wschin merged commit f8c78d0 into dotnet:master Apr 10, 2019
@wschin wschin deleted the enable-sse-and-omp branch April 10, 2019 23:23
wschin added a commit to wschin/machinelearning that referenced this pull request Apr 11, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Mar 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants