Updated CopyColumns, DropColumns and SelectColumns samples. #3268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeahmed
requested review from
Ivanidzo4ka,
shmoradims,
singlis,
sfilipi and
rogancarr
artidoro
reviewed
Apr 10, 2019
| // Create a small dataset as an IEnumerable. | ||
| var samples = new List<InputData>() | ||
| { | ||
| new InputData(){ ImageId = 1, Features = new [] { 1.0f, 1.0f, 1.0f} }, |
There was a problem hiding this comment.
Features [](start = 46, length = 8)
You don't seem to need Features.
artidoro
reviewed
Apr 10, 2019
| { | ||
| public float CustomValue { get; set; } | ||
| public int ImageId { get; set; } | ||
| public float[] Features { get; set; } |
There was a problem hiding this comment.
Features [](start = 27, length = 8)
Same here, I think you can drop it.
artidoro
reviewed
Apr 10, 2019
| // Parameter name: Schema | ||
|
|
||
| // And we can write a few columns out to see that the rest of the data is still available. | ||
| var rowEnumerable = mlContext.Data.CreateEnumerable<SampleInfertDataTransformed>(transformedData, reuseRowObject: false); | ||
| var rowEnumerable = mlContext.Data.CreateEnumerable<TransformedData>(transformedData, reuseRowObject: false); | ||
| Console.WriteLine($"The columns we didn't drop are still available."); | ||
| foreach (var row in rowEnumerable) | ||
| { |
There was a problem hiding this comment.
{ [](start = 12, length = 1)
Please remove the brace, not needed for a one line loop. #Resolved
artidoro
reviewed
Apr 10, 2019
|
|
||
| // And finally, we can write out the rows of the dataset, looking at the columns of interest. | ||
| Console.WriteLine($"Label, Parity, and CustomValue columns obtained post-transformation."); | ||
| Console.WriteLine($"Label and ImageId columns obtained post-transformation."); | ||
| foreach (var row in rowEnumerable) | ||
| { |
There was a problem hiding this comment.
{ [](start = 12, length = 1)
Please remove the braces as we don't need them for a one line loop. #Resolved
Codecov Report
@@ Coverage Diff @@
## master #3268 +/- ##
==========================================
- Coverage 72.62% 72.62% -0.01%
==========================================
Files 807 807
Lines 145080 145080
Branches 16213 16213
==========================================
- Hits 105367 105361 -6
- Misses 35296 35302 +6
Partials 4417 4417
|
singlis
reviewed
Apr 10, 2019
|
|
||
| // CopyColumns is commonly used to rename columns. | ||
| // For example, if you want to train towards Age, and your learner expects a "Label" column, you can | ||
| // use CopyColumns to rename Age to Label. Technically, the Age columns still exists, but it won't be | ||
| // For example, if you want to train towards ImageId, and your learner expects a "Label" column, you can |
There was a problem hiding this comment.
learner [](start = 75, length = 7)
Should this be trainer? #Resolved
singlis
reviewed
Apr 10, 2019
| // Case: 1 Induced: 2 Parity: 6 | ||
| // Case: 1 Induced: 2 Parity: 4 | ||
| // Case: 1 Induced: 1 Parity: 3 | ||
| // Age: 21 Geneder: Male Education: BS |
There was a problem hiding this comment.
Gender is mispelled #Resolved
singlis
reviewed
Apr 10, 2019
| }; | ||
|
|
||
| // Convert training data to IDataView. | ||
| var dataview = mlContext.Data.LoadFromEnumerable(samples); | ||
|
|
||
| // Select a subset of columns to keep. | ||
| var pipeline = mlContext.Transforms.SelectColumns("Age", "Education"); | ||
|
|
||
| // Now we can transform the data and look at the output to confirm the behavior of CopyColumns. |
There was a problem hiding this comment.
behavior of SelectColumns #Resolved
zeahmed
added a commit
to zeahmed/machinelearning
that referenced
this pull request
Apr 11, 2019
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1209.