Add a doc template to SkipTakeFilter #3415
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3415 +/- ##
==========================================
+ Coverage 72.69% 72.69% +<.01%
==========================================
Files 807 807
Lines 145171 145171
Branches 16225 16225
==========================================
+ Hits 105536 105539 +3
+ Misses 35220 35219 -1
+ Partials 4415 4413 -2
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #3415 +/- ##
==========================================
+ Coverage 72.69% 72.69% +<.01%
==========================================
Files 807 807
Lines 145171 145171
Branches 16225 16225
==========================================
+ Hits 105536 105539 +3
+ Misses 35220 35219 -1
+ Partials 4415 4413 -2
|
| /// ]]> | ||
| /// </format> | ||
| /// </remarks> | ||
| /// <seealso cref="Microsoft.ML.DataOperationsCatalog.SkipRows(Microsoft.ML.IDataView,System.Int64)" /> |
There was a problem hiding this comment.
SkipRows [](start = 58, length = 8)
What's the point of all this if class for this summary is internal?
There was a problem hiding this comment.
also, I'd leave the filters out, since they don't change the schema.
In reply to: 276867180 [](ancestors = 276867180)
There was a problem hiding this comment.
We don't need this 'internal' change. Also filters are different from transforms and don't return an estimator. they return an IDV.
The actual public API is here:
I see that Rogan has already polished them as part of the samples. I think they're in good shape. I'll close this PR. If you think otherwise, please reopen.
In reply to: 276907066 [](ancestors = 276907066,276867180)
| @@ -26,8 +26,23 @@ | |||
| namespace Microsoft.ML.Transforms | |||
| { | |||
| /// <summary> | |||
| /// Allows limiting input to a subset of row at an optional offset. Can be used to implement data paging. | |||
| /// Allows limiting input to a subset of row at an optional offset. It can either take first <see cref="_take"/> rows and ignore all others. | |||
There was a problem hiding this comment.
row [](start = 45, length = 3)
rows
|
Looks like this was already covered by Rogan as part of samples work. Please see my comment above for details. Closing this PR for now. |
ghost
locked as resolved and limited conversation to collaborators
Toward #3204.