Towards #3204 -FeatureSelection #3424
Conversation
| @@ -18,7 +18,47 @@ | |||
|
|
|||
| namespace Microsoft.ML.Transforms | |||
| { | |||
| /// <include file='doc.xml' path='doc/members/member[@name="CountFeatureSelection"]' /> | |||
| /// <summary> | |||
| /// Selects the slots for which the count of non-default values is greater than or equal to a threshold. | |||
There was a problem hiding this comment.
default values [](start = 54, length = 14)
create new issue for later: we need to specify for each input type what's the default value. for e.g. it's not clear if for text, default is null, empty string, or whitespaces. same goes with key type. #Resolved
| /// |True |4,0 | | ||
| /// |False|0,5 | | ||
| /// |True |4,0 | | ||
| /// |False|0,5 | |
There was a problem hiding this comment.
do we need these examples? we already have similar samples. #Resolved
There was a problem hiding this comment.
it is really hard to understand without them, i think.
The samples should be for how to use it, not to understand what is it doing. @natke what do you think?
#Resolved
There was a problem hiding this comment.
I like the samples. It helped me understand when I read it. #Resolved
| /// The count feature selection can remove the features generated by the hash transform that have no data in the examples. | ||
| /// | ||
| /// For example, if we set the count to 3 and fit the estimator, apply the transformer to the following Features column, | ||
| /// we would see the second solot, containing: NaN, 5, 5, NaN values being dropped because that slot has only two non-default values, the two 5 values. |
There was a problem hiding this comment.
solot [](start = 32, length = 5)
slot
please use spell checker. we won't catch all the typos manually.
https://marketplace.visualstudio.com/items?itemName=EWoodruff.VisualStudioSpellChecker #Resolved
sfilipi
force-pushed
the
featureSelection
branch
from
66e760c to
67a22c4
Compare
ghost
locked as resolved and limited conversation to collaborators
Adhering to the #3204 template for the FeatureSelection estimator and transformer.