Skip to content

XML documentation for Time Series #3444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 21, 2019
Merged

XML documentation for Time Series #3444

merged 5 commits into from
Apr 21, 2019

Conversation

wschin
Copy link
Member

@wschin wschin commented Apr 19, 2019

Toward #3204 for time series.

@wschin wschin added the documentation Related to documentation of ML.NET label Apr 19, 2019
@wschin wschin self-assigned this Apr 19, 2019
@shauheen
Copy link
Contributor

@wschin please update the PR title to something more understandable.

@wschin wschin changed the title Time xml Time Series XML Apr 20, 2019
@wschin wschin requested review from natke, shmoradims and sfilipi and removed request for natke and shmoradims April 20, 2019 22:17
@shauheen shauheen changed the title Time Series XML XML documentation for Time Series Apr 20, 2019
Copy link

@shmoradims shmoradims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@shauheen
Copy link
Contributor

@wschin please update the PR title to something more understandable.

Done

@codecov
Copy link

codecov bot commented Apr 20, 2019

Codecov Report

Merging #3444 into master will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3444      +/-   ##
==========================================
+ Coverage   72.73%   72.76%   +0.03%     
==========================================
  Files         807      808       +1     
  Lines      145206   145452     +246     
  Branches    16230    16244      +14     
==========================================
+ Hits       105613   105839     +226     
- Misses      35176    35192      +16     
- Partials     4417     4421       +4
Flag Coverage Δ
#Debug 72.76% <ø> (+0.03%) ⬆️
#production 68.27% <ø> (ø) ⬆️
#test 89.04% <ø> (+0.06%) ⬆️
Impacted Files Coverage Δ
.../Microsoft.ML.TimeSeries/IidChangePointDetector.cs 69.82% <ø> (ø) ⬆️
...Microsoft.ML.TimeSeries/IidAnomalyDetectionBase.cs 88.88% <ø> (ø) ⬆️
src/Microsoft.ML.TimeSeries/IidSpikeDetector.cs 72.54% <ø> (ø) ⬆️
src/Microsoft.ML.TimeSeries/SsaSpikeDetector.cs 82.9% <ø> (ø) ⬆️
src/Microsoft.ML.TimeSeries/ExtensionsCatalog.cs 93.33% <ø> (ø) ⬆️
...Microsoft.ML.TimeSeries/SsaAnomalyDetectionBase.cs 80.82% <ø> (ø) ⬆️
.../Microsoft.ML.TimeSeries/SsaChangePointDetector.cs 77.51% <ø> (ø) ⬆️
src/Microsoft.ML.Transforms/Text/LdaTransform.cs 89.26% <0%> (-0.63%) ⬇️
...ft.ML.Data/Evaluators/BinaryClassifierEvaluator.cs 77.18% <0%> (-0.01%) ⬇️
...ML.Data/Transforms/ColumnConcatenatingEstimator.cs 80.3% <0%> (ø) ⬆️
... and 59 more

Copy link
Member

@sfilipi sfilipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@shauheen shauheen merged commit 10208cb into dotnet:master Apr 21, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Mar 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Related to documentation of ML.NET
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants