Skip to content

XML documentation for DNN Image Featurizer Transfomer. #3456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 22, 2019
Merged

XML documentation for DNN Image Featurizer Transfomer. #3456

merged 2 commits into from
Apr 22, 2019

Conversation

codemzs
Copy link
Member

@codemzs codemzs commented Apr 22, 2019

towards #3204 .

@codemzs codemzs requested review from natke, shmoradims and sfilipi April 22, 2019 03:47
@codemzs codemzs added the documentation Related to documentation of ML.NET label Apr 22, 2019
@sfilipi
Copy link
Member

sfilipi commented Apr 22, 2019 •
edited by codemzs
Loading 

    /// <param name="inputColumnName">Name of column to transform.

type. #Resolved

Refers to: src/Microsoft.ML.OnnxTransformer/OnnxCatalog.cs:82 in a17be90. [](commit_id = a17be90, deletion_comment = False)

sfilipi
sfilipi approved these changes Apr 22, 2019
View reviewed changes
Copy link
Member

@sfilipi sfilipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

natke
natke approved these changes Apr 22, 2019
View reviewed changes
Copy link
Contributor

@natke natke left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good. Agree with @sfilipi's and @shmoradims comments.

shmoradims
shmoradims approved these changes Apr 22, 2019
View reviewed changes
Copy link

@shmoradims shmoradims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@codemzs codemzs merged commit 5b3312d into dotnet:master Apr 22, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Mar 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shmoradims shmoradims shmoradims approved these changes

@natke natke natke approved these changes

@sfilipi sfilipi sfilipi approved these changes

Assignees
No one assigned
Labels
documentation Related to documentation of ML.NET
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@codemzs @sfilipi @natke @shmoradims