Reference to See Also section for example of usage in all estimators #3577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artidoro
commented
Apr 25, 2019
| @@ -876,6 +876,8 @@ public VBuffer<ReadOnlyMemory<char>>[] SlotNamesMetadata(out VectorDataViewType[ | |||
| /// <xref:Microsoft.ML.Transforms.Text.NgramHashingEstimator> is different from <xref:Microsoft.ML.Transforms.Text.WordHashBagEstimator> | |||
| /// in a way that The former takes tokenized text as input while the latter tokenizes text internally. | |||
| /// Check the See Also section for links to examples of the usage. | |||
There was a problem hiding this comment.
Check [](start = 8, length = 5)
Duplicate.
sfilipi
reviewed
Apr 25, 2019
| Forests](https://blogs.technet.microsoft.com/machinelearning/2014/09/10/from-stumps-to-trees-to-forests/) | ||
|
|
||
| Check the See Also section for links to examples of the usage. |
There was a problem hiding this comment.
"to examples of the usage" doesn't sound well..
I think they should all be "to usage examples."
Sorry.. probably should have put that in the bug..
There was a problem hiding this comment.
I agree with @sfilipi but we could live with what is here
natke
approved these changes
Apr 25, 2019
| Forests](https://blogs.technet.microsoft.com/machinelearning/2014/09/10/from-stumps-to-trees-to-forests/) | ||
|
|
||
| Check the See Also section for links to examples of the usage. |
There was a problem hiding this comment.
I agree with @sfilipi but we could live with what is here
Codecov Report
@@ Coverage Diff @@
## master #3577 +/- ##
=========================================
Coverage ? 72.78%
=========================================
Files ? 808
Lines ? 145452
Branches ? 16244
=========================================
Hits ? 105866
Misses ? 35163
Partials ? 4423
|
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIxes #3485.