-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[AutoML] CLI telemetry rev #3789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
3d2166a
v0 changes
daholste 0814b16
add application exit event
daholste 6236345
add machine learning task type to experiment & experiment iteration m…
daholste b8211f1
remove duplicate property
daholste 7f685c3
Merge remote-tracking branch 'upstream/features/automl' into telemetry
daholste 535e6c2
merge
daholste c10191d
only flush telemetry once at end of application exit; lower flush tim…
daholste d187320
add command attribute to every telemetry event
daholste e5cd512
remove explicit command property add from MLNetCommandEvent, since it…
daholste 1b518ff
increase telemetry flush timeout from 1 to 3 seconds
daholste d4069cc
delete not useful MLNet command end event
daholste File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
// Licensed to the .NET Foundation under one or more agreements. | ||
// The .NET Foundation licenses this file to you under the MIT license. | ||
// See the LICENSE file in the project root for more information. | ||
|
||
using System; | ||
using System.Collections.Generic; | ||
using System.Diagnostics; | ||
|
||
namespace Microsoft.ML.CLI.Telemetry.Events | ||
{ | ||
/// <summary> | ||
/// Telemetry event for CLI application exit. | ||
/// </summary> | ||
internal class ApplicationExitEvent | ||
{ | ||
public static void TrackEvent(int exitCode, bool commandParseSucceeded, TimeSpan duration, Exception ex) | ||
{ | ||
Telemetry.TrackEvent("application-exit", | ||
new Dictionary<string, string> | ||
{ | ||
{ "CommandParseSucceeded", commandParseSucceeded.ToString() }, | ||
{ "ExitCode", exitCode.ToString() }, | ||
{ "PeakMemory", Process.GetCurrentProcess().PeakWorkingSet64.ToString() }, | ||
}, | ||
duration, ex); | ||
} | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
// Licensed to the .NET Foundation under one or more agreements. | ||
// The .NET Foundation licenses this file to you under the MIT license. | ||
// See the LICENSE file in the project root for more information. | ||
|
||
using System; | ||
using System.Collections.Generic; | ||
using System.Diagnostics; | ||
using System.Linq; | ||
using Microsoft.ML.AutoML; | ||
|
||
namespace Microsoft.ML.CLI.Telemetry.Events | ||
{ | ||
/// <summary> | ||
/// Telemetry event for AutoML experiment completion. | ||
/// </summary> | ||
internal static class ExperimentCompletedEvent | ||
{ | ||
public static void TrackEvent<TMetrics>(RunDetail<TMetrics> bestRun, | ||
List<RunDetail<TMetrics>> allRuns, | ||
TaskKind machineLearningTask, | ||
TimeSpan duration) | ||
{ | ||
Telemetry.TrackEvent("experiment-completed", | ||
new Dictionary<string, string>() | ||
{ | ||
{ "BestIterationNum", (allRuns.IndexOf(bestRun) + 1).ToString() }, | ||
{ "BestPipeline", Telemetry.GetSanitizedPipelineStr(bestRun.Pipeline) }, | ||
{ "BestTrainer", bestRun.TrainerName }, | ||
{ "MachineLearningTask", machineLearningTask.ToString() }, | ||
{ "NumIterations", allRuns.Count().ToString() }, | ||
{ "PeakMemory", Process.GetCurrentProcess().PeakWorkingSet64.ToString() }, | ||
}, | ||
duration); | ||
} | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks to me this can be a more terse implementation using linq grouping. are we anti-linq in this repo? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love LINQ! Here, I think the existing way is more readable, but I see where you're coming from. Style is so idiosyncratic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is my version, you think this isn't that readable? Fair warning, I haven't tested if it works :)