[WIP] Add Debugger display attribute #402
Conversation
|
Hi @jwood803 , I'm not sure this will work since this is using the short names, rather than the actual field names of the properties. Also the criteria of |
| @@ -214,6 +214,12 @@ private void GenerateClasses(IndentingTextWriter writer, Type inputType, ModuleC | |||
| classBase = $" : OneToOneColumn<{apiName}>, IOneToOneColumn"; | |||
| else if (type.IsSubclassOf(typeof(ManyToOneColumn))) | |||
| classBase = $" : ManyToOneColumn<{apiName}>, IManyToOneColumn"; | |||
|
|
|||
| if (inputAttr.ShortName != null && inputAttr.SortOrder < 10) | |||
There was a problem hiding this comment.
I'm sure this isn't the right way to check if the attribute should be included or not. Would need some guidance on if the ShortName is the best one to use and how best to use the SortOrder.
There was a problem hiding this comment.
The debugger display attribute's format strings would correspond to the property name exactly, since otherwise the debugger won't have any idea what to make of it. Those properties, as we see, are generated on this line, so if we use them we'll have to use roughly the same code.
As you can see, the short name is not used here at all.
Also: my original suggestion in #194 is to only include in the display formatted string those parameters with the SortOrder property set (so not an arbitrary threshold, just whether it had been set at all or not -- elsewhere we use this sort order property ) and of course only those types that would display well... which is to say, probably simple types like strings, ints, floats, doubles, etc. Not sure how well arrays display in this scheme.
To be fair, I'm not actually entirely clear how this code works -- it looks like we're in the middle of an iteration over the field, but then we're in the middle of this loop writing out the class? I think perhaps @codemzs understands this code a bit better and can advise more exactly.
One thing to keep in mind is: once #371 is realized, we will no longer be generating C# code to generate JSON then pass it through reflection base mechanisms to call, again, C# code, we will instead just call the underlying C# code directly. When that happens this generator will go away.
In reply to: 197821103 [](ancestors = 197821103)
|
Thanks for the feedback, @TomFinley! The And it seems I didn't know how to use the review system. I had a comment that I thought was public but I guess it isn't until I hit the "Review" button. Apologies about that. 😛 |
| @@ -214,6 +214,12 @@ private void GenerateClasses(IndentingTextWriter writer, Type inputType, ModuleC | |||
| classBase = $" : OneToOneColumn<{apiName}>, IOneToOneColumn"; | |||
| else if (type.IsSubclassOf(typeof(ManyToOneColumn))) | |||
| classBase = $" : ManyToOneColumn<{apiName}>, IManyToOneColumn"; | |||
|
|
|||
| if(inputAttr.SortOrder > 0) | |||
There was a problem hiding this comment.
I think this is better @TomFinley, but just let me konw if I'm going down the wrong path.
|
@jwood803 , I will be closing this PR, since |
ghost
locked as resolved and limited conversation to collaborators
Proposed fix for #194.
Updated the
CSharpAPIGeneratorfile to include theDebuggerDisplayattribute.Marked as WIP since I'm sure this would need to be improved.