Enabling building ML.NET for .NET Core 3.0 in the official builds. #4096
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Combine the two separate CpuMath UnitTest projects into a single project.
safern
reviewed
Aug 12, 2019
safern
reviewed
Aug 12, 2019
…ed in the NuGet package. We don't need many things from the Tools directory, so removing crossgen won't affect build performance very much.
safern
approved these changes
Aug 13, 2019
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for the C# hardware intrinsics code written last summer to be used in official builds.
It also allows us to take advantage of other new APIs in .NET Core 3.0 in the future.