Move windows build machines to NetCorePublic-Pool. #4375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eerhardt
reviewed
Oct 24, 2019
Codecov Report
@@ Coverage Diff @@
## master #4375 +/- ##
==========================================
- Coverage 74.66% 74.63% -0.03%
==========================================
Files 883 883
Lines 155117 155117
Branches 16931 16931
==========================================
- Hits 115814 115775 -39
- Misses 34549 34598 +49
+ Partials 4754 4744 -10
|
safern
reviewed
Oct 24, 2019
| @@ -65,7 +65,8 @@ jobs: | |||
| name: Windows_x64_NetCoreApp21 | |||
| buildScript: build.cmd | |||
| pool: | |||
| name: Hosted VS2017 | |||
| name: NetCorePublic-Pool | |||
| queue: buildpool.windows.10.amd64.vs2017.open | |||
There was a problem hiding this comment.
Should we instead build on VS2019?
There was a problem hiding this comment.
It probably doesn't matter either way. The only thing we use the VS on the machine for is the C++ compiler.
But if we wanted to update all of them to vs2019, that would be OK with me. But I don't think it is 100% required.
There was a problem hiding this comment.
I just ask because there has been discussions for corefx and other repos that we should be using the latest toolset to dogfood... but that can be done in a separate PR.
safern
approved these changes
Oct 24, 2019
codemzs
added a commit
to codemzs/machinelearning
that referenced
this pull request
Oct 24, 2019
…)" This reverts commit c922529.
codemzs
added a commit
that referenced
this pull request
Oct 25, 2019
frank-dong-ms-zz
pushed a commit
to frank-dong-ms-zz/machinelearning
that referenced
this pull request
Nov 4, 2019
* Move windows build machines to NetCorePublic-Pool. * PR feedback. * PR feedback.
frank-dong-ms-zz
pushed a commit
to frank-dong-ms-zz/machinelearning
that referenced
this pull request
Nov 4, 2019
…t#4377) * Revert "Move windows build machines to NetCorePublic-Pool. (dotnet#4375)" This reverts commit c922529. * Add step to cleanup test data before building packages to free up space * Increase build timeout.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds seem to be failing because it runs out of disk space.