Skip to content

Added documentation regarding TextLoader's hasHeader field #4654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 16 commits into from

Conversation

mstfbl
Copy link
Contributor

@mstfbl mstfbl commented Jan 15, 2020

Fixes #3053

Added note regarding TextLoader's hasHeader field per @yaeldekel 's suggestion in #3053.

Attempt on Issue 4169

- Added the necessary estimator pipeline for a KeyDataViewType string/value binding
- Changed the Output Column types of the ImageClassificationEstimator and  the Mapper for future compatibility with KeyType composite values
Here, I isolated the issue of the annotations which carry the KeyValues not copying over to the SchemaShapes in the SchemaShape Create method in IEstimator.cs. In this method, the KeyValues are not being recognized as KeyType, and as a result the annotations are not being copied over.
…elearning into Issue_4169"

This reverts commit 01c77c9, reversing
changes made to d490383.
This reverts commit d490383.
@mstfbl mstfbl requested a review from a team as a code owner January 15, 2020 01:59
@mstfbl mstfbl closed this Jan 15, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Mar 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Defining a TextLoader with hasHeader=true and no data sample results in no slot names
1 participant