-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Added documentation regarding TextLoader's hasHeader field #4654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempt on Issue 4169 - Added the necessary estimator pipeline for a KeyDataViewType string/value binding - Changed the Output Column types of the ImageClassificationEstimator and the Mapper for future compatibility with KeyType composite values
Here, I isolated the issue of the annotations which carry the KeyValues not copying over to the SchemaShapes in the SchemaShape Create method in IEstimator.cs. In this method, the KeyValues are not being recognized as KeyType, and as a result the annotations are not being copied over.
…king on test cases
…elearning into Issue_4169" This reverts commit 01c77c9, reversing changes made to d490383.
This reverts commit d490383.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3053
Added note regarding TextLoader's hasHeader field per @yaeldekel 's suggestion in #3053.