Skip to content

Added documentation regarding TextLoader's hasHeader field #4655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Feb 7, 2020

Conversation

mstfbl
Copy link
Contributor

@mstfbl mstfbl commented Jan 15, 2020

Fixes #3053

Added note regarding TextLoader's hasHeader field per @yaeldekel 's suggestion in #3053.

@mstfbl mstfbl requested a review from a team as a code owner January 15, 2020 02:09
Copy link
Contributor

@harishsk harishsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

@codecov
Copy link

codecov bot commented Jan 17, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@d85be83). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #4655   +/-   ##
=========================================
  Coverage          ?   75.83%           
=========================================
  Files             ?      951           
  Lines             ?   172292           
  Branches          ?    18589           
=========================================
  Hits              ?   130657           
  Misses            ?    36458           
  Partials          ?     5177
Flag Coverage Δ
#Debug 75.83% <ø> (?)
#production 71.43% <ø> (?)
#test 90.6% <ø> (?)
Impacted Files Coverage Δ
.../Microsoft.ML.Data/DataLoadSave/Text/TextLoader.cs 82.22% <ø> (ø)

@mstfbl mstfbl requested review from harishsk and yaeldekel January 21, 2020 21:13
@mstfbl mstfbl requested a review from yaeldekel January 23, 2020 18:36
@mstfbl mstfbl requested review from harishsk and yaeldekel February 3, 2020 10:53
@mstfbl mstfbl merged commit d6e64cb into dotnet:master Feb 7, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Mar 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Defining a TextLoader with hasHeader=true and no data sample results in no slot names
3 participants