Skip to content

[Test Stability] PR to Test BinaryClassifierSymSgdTest #4722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

antoniovs1029
Copy link
Member

PR to Test BinaryClassifierSymSgdTest

@antoniovs1029 antoniovs1029 changed the title PR to Test BinaryClassifierSymSgdTest [Test Stability] PR to Test BinaryClassifierSymSgdTest Jan 31, 2020
@antoniovs1029 antoniovs1029 reopened this Jan 31, 2020
@sharwell
Copy link
Member

BinaryClassifierSymSgdTest

This is the test most impacted by CNR (#4569). It will not be possible to stabilize this test without one of the following:

  1. Enabling conditional numerical reproducibility
  2. Internally switching to aligned data vectors before calling into the MKL BLAS implementation (this will fix some sources of flakiness, but perhaps not all of them)

@sharwell
Copy link
Member

@antoniovs1029 I have now updated #4569; you should be able to test this again after it is merged.

@antoniovs1029
Copy link
Member Author

So I've updated this with the different baselines for each platform, and enabling CNR, and it has passed on pretty much all builds (except for one, which was cancelled because of a timeout while downloading the data for benchmarks). This experiment consisted of running this test 100 times along with all the other enabled tests.

Now I am going to rerun this, but now running it along all the other tests (including the disabled ones), just to double check.

@antoniovs1029
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Pull request contains merge conflicts.

@antoniovs1029
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@antoniovs1029
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@antoniovs1029
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@antoniovs1029
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@harishsk harishsk closed this Feb 14, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Mar 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
test related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants