add run specific test capability and CrashTestHostProcessorHelper #4744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harishsk
reviewed
Jan 30, 2020
| @@ -0,0 +1,14 @@ | |||
| using System; | |||
There was a problem hiding this comment.
I know I had asked you to add this, but on second thoughts, it doesn't seem to add much. It is simply a rename over an existing function. Maybe we can delete this and just use Environment.FailFast directly wherever we would have called CrashTestHostProcessHelper.CrashTestHostProcess()
Maybe we should delete this.
There was a problem hiding this comment.
Yes, it is just one line function I'm okay with delete this.
In reply to: 373198033 [](ancestors = 373198033)
harishsk
approved these changes
Jan 30, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 purpose for this PR:
a. set innerLoop to false to certain configuration
b. set runSpecific to true to certain configuration
c. add [Trait("Category", "RunSpecificTests")] to the test methods wish to run