Updates NetCoreApp 3.0 builds to NetCoreApp 3.1 #4888
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstfbl
force-pushed
the
netcoreapp3.0to3.1
branch
from
dd5ec10 to
ba1757b
Compare
harishsk
reviewed
Mar 23, 2020
| @@ -13,20 +13,20 @@ resources: | |||
| jobs: | |||
| - template: /build/ci/job-template.yml | |||
| parameters: | |||
| name: Centos_x64_NetCoreApp30 | |||
| name: Centos_x64_NetCoreApp31 | |||
There was a problem hiding this comment.
I don't think we will support multiple versions of .netcoreapp 3.x.
Can we simply make the whole thing NetCoreApp3?
There was a problem hiding this comment.
That makes sense, though I do think that specifying which version of NetCoreApp3 (3.0 or 3.1) we're using would be helpful if in the future we see bugs that are specific to 3.0 or 3.1, as you pointed out with respect to #4933 .
I will update these references to version 3.0/3.1 to only have version "3", if you do believe that specifying the exact iteration of NetCoreApp3 won't be helpful as I mentioned above.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4865 . Updates our builds using NetCoreApp 3.0 to NetCoreApp 3.1.