Image support #528

Ivanidzo4ka · 2018-07-13T14:30:02Z

address #489
need create issue about IDataView datatype extensibility.

add VectorToImage transform add first test

TomFinley · 2018-07-13T14:53:29Z

src/Microsoft.ML.ImageAnalytics/ImageType.cs

+        {
+            Contracts.CheckParam(height > 0, nameof(height));
+            Contracts.CheckParam(width > 0, nameof(width));
+            Contracts.CheckParam((long)height * width <= int.MaxValue / 4, nameof(height), "height * width is too large");


height [](start = 92, length = 6)

nameof for params in this message? #Closed

TomFinley · 2018-07-13T14:55:59Z

src/Microsoft.ML.ImageAnalytics/ImageType.cs

+        public override string ToString()
+        {
+            if (Height == 0 && Width == 0)
+                return "Picture";


Picture [](start = 24, length = 7)

It's a little weird that the image type identifies itself as picture, is it not? #Closed

TomFinley · 2018-07-13T14:56:44Z

src/Microsoft.ML.ImageAnalytics/ImageType.cs

+                return false;
+            if (Width != tmp.Width)
+                return false;
+            return true;


Maybe restructure as return Width == tmp.Width. #Closed

TomFinley · 2018-07-13T14:58:52Z

src/Microsoft.ML.ImageAnalytics/ImageType.cs

+            if (other == this)
+                return true;
+            var tmp = other as ImageType;
+            if (tmp == null)


Will if (other as ImageType tmp == null) work? #Closed

TomFinley · 2018-07-13T15:04:34Z

src/Microsoft.ML.ImageAnalytics/ImageType.cs

+        {
+        }
+
+        public override bool Equals(ColumnType other)


Equals [](start = 29, length = 6)

There's something a bit strange about this. ColumnType implements IEquatable<ColumnType>, and the guidelines for that say it should also overload Equals(object) and GetHashCode. Though to be fair to you I think all ColumnTypes have this problem. #Closed

Maybe file a separate issue, we can address later?

In reply to: 202379905 [](ancestors = 202379905)

#547

In reply to: 203182127 [](ancestors = 203182127,202379905)

TomFinley · 2018-07-13T15:14:45Z

test/data/images/images.tsv

@@ -0,0 +1,3 @@
+banana.jpg	banana
+hotdog.jpg	hotdog
+tomato.jpg	tomato


I feel like this should have been "not hotdog." 😃 #Closed

sfilipi · 2018-07-16T16:31:16Z

src/Microsoft.ML.ImageAnalytics/ImagePixelExtractorTransform.cs

+namespace Microsoft.ML.Runtime.Data
+{
+    // REVIEW: Rewrite as LambdaTransform to simplify.
+    public sealed class ImagePixelExtractorTransform : OneToOneTransformBase


ImagePixelExtractorTransform [](start = 24, length = 28)

Are you planning to add their entry point classes next? #Resolved

sfilipi · 2018-07-16T16:35:27Z

src/Microsoft.ML.ImageAnalytics/ImageResizerTransform.cs

+namespace Microsoft.ML.Runtime.Data
+{
+    // REVIEW: Rewrite as LambdaTransform to simplify.
+    public sealed class ImageResizerTransform : OneToOneTransformBase


Let's get in the rhythm of adding one line of
for all public classes. #Resolved

sfilipi · 2018-07-16T16:35:45Z

src/Microsoft.ML.ImageAnalytics/ImagePixelExtractorTransform.cs

+namespace Microsoft.ML.Runtime.Data
+{
+    // REVIEW: Rewrite as LambdaTransform to simplify.
+    public sealed class ImagePixelExtractorTransform : OneToOneTransformBase


ImagePixelExtractorTransform [](start = 24, length = 28)

Let's get in the rhythm of adding one line of
for all public classes. #Resolved

sfilipi · 2018-07-16T16:35:58Z

src/Microsoft.ML.ImageAnalytics/ImageLoaderTransform.cs

+namespace Microsoft.ML.Runtime.Data
+{
+    // REVIEW: Rewrite as LambdaTransform to simplify.
+    public sealed class ImageLoaderTransform : OneToOneTransformBase


ImageLoaderTransform [](start = 24, length = 20)

summary #Resolved

sfilipi · 2018-07-16T16:43:48Z

src/Microsoft.ML.ImageAnalytics/ImageGrayscaleTransform.cs

+
+        /// <summary>
+        /// Public constructor corresponding to SignatureDataTransform.
+        /// </summary>


I know we use this allover, and it's plenty meaningful as a code comment, but it will appear in the docs site as well, where might confuse users. Maybe turn it into a code comment removing the triple ///, and
.
Ideally add a meaningful line for the actual documentation. #Resolved

sfilipi

address some comment. remove SetResolution calls. unify namespace.

Ivanidzo4ka · 2018-07-16T22:11:52Z

@dotnet-bot test Windows_NT Release

Ivanidzo4ka · 2018-07-17T17:43:02Z

@dotnet-bot test Linux Debug

TomFinley · 2018-07-17T21:17:12Z

src/Microsoft.ML.ImageAnalytics/ImageType.cs

+        {
+            Contracts.CheckParam(height > 0, nameof(height));
+            Contracts.CheckParam(width > 0, nameof(width));
+            Contracts.CheckParam((long)height * width <= int.MaxValue / 4, nameof(height), $"{nameof(height)} * {nameof(width)} is too large");


$"{nameof(height)} * {nameof(width)} is too large" [](start = 91, length = 50)

If you really want it as format strings I'd encourage you to make this follow the if (...) throw Contracts.Except pattern. Or you could continue to make it a string literal by making this nameof(height) + " * " + nameof(width) + " is too large" or something. #Closed

TomFinley · 2018-07-17T21:19:41Z

src/Microsoft.ML.ImageAnalytics/ImageLoaderTransform.cs

+            public string ImageFolder;
+        }
+
+        internal const string Summary = "Load images from a file.";


a file [](start = 58, length = 6)

You forgot to pluralize this. #Closed

is "a files" ok, or it should be something else?

In reply to: 203182343 [](ancestors = 203182343)

Correct would be "load images from files." FYI @Ivanidzo4ka I feel like this is the only thing standing in the way of this being merged.

In reply to: 205597457 [](ancestors = 205597457,203182343)

Grayscale return exception catching

different image height and image width

Zruty0 · 2018-07-25T16:14:00Z

@Ivanidzo4ka , you have surely added a lot of code here :) I would much rather ask @TomFinley to finish his review, rather than jump in and try to grok all this myself.

@TomFinley , if for some reason this doesn't work for you, please let me know and I'll start the review

TomFinley · 2018-07-25T21:03:05Z

src/Microsoft.ML.ImageAnalytics/ImageGrayscaleTransform.cs

+
+        private const string RegistrationName = "ImageGrayscale";
+
+        /// Public constructor corresponding to SignatureDataTransform.


/// [](start = 8, length = 4)

Did you mean this to be // and not /// , since it is not really terribly sensible for callers? #Closed

TomFinley · 2018-07-25T21:05:33Z

src/Microsoft.ML.ImageAnalytics/ImageGrayscaleTransform.cs

+            return Infos[iinfo].TypeSrc;
+        }
+
+        public ColorMatrix GreyscaleColorMatrix = new ColorMatrix(


public ColorMatrix GreyscaleColorMatrix [](start = 8, length = 39)

This is a mutable, public instance level field that affects the functionality of the transform.

Probably want this to be private (or at least internal if somehow it is referenced somewhere else), static, and almost certainly readonly. #Closed

TomFinley · 2018-07-25T21:15:48Z

src/Microsoft.ML.ImageAnalytics/ImagePixelExtractorTransform.cs

+                //verWrittenCur: 0x00010001, // Initial
+                verWrittenCur: 0x00010002, // Swith from OpenCV to Bitmap
+                verReadableCur: 0x00010002,
+                verWeCanReadBack: 0x00010002,


0x00010002 [](start = 34, length = 10)

What would happen if you were to read a 0x00010001 model? Would it just be a little bit off? Or is it just fundamentally different?

I think possibly it might be better to load those old models, just use the new types under the hood. If we were to, say, hypothetically change from using DvText to ReadOnlySpan<char> or something like that, we almost certainly would not refuse to load all models just on the basis of the type change alone. #Closed

In past Loader/Resizer and Pixel extractor was tangled bundle which works together.
From what I found in my investigation during comparing System.Bitmap with old version, Pixel extractor was buggy and throw exception in case of rectangular shape (people used square shape all the time, but maybe rectangle image make sense as well) and Resizer instead of resizing image actually just pick subset of image from top left corner and count it as "Resized" image. Which is fine if you pass real width and height to transform, but if you actually want to resize them, not so great.

That's why I'm bumping versions in all 3 of them.

In reply to: 205264997 [](ancestors = 205264997)

Ah OK. So they were not just somewhat different, the old ones were fundamentally broken. That's nice. I guess that's a good enough reason to break backcompat. #Closed

TomFinley · 2018-07-25T21:19:07Z

src/Microsoft.ML.ImageAnalytics/ImageGrayscaleTransform.cs

+        private static VersionInfo GetVersionInfo()
+        {
+            return new VersionInfo(
+                modelSignature: "IMGGREY ",


IMGGREY [](start = 33, length = 8)

You had a signature of IMGLOADT for that. Why is this not IMGGREYT?

Also: is it intentional that this be GREY? Elsewhere we are using "gray."

If models already exist with this signature I guess we have to keep it, not sure if that's the case though since you didn't bump the version. :) (I'm not suggesting you bump the version to be clear.) #Closed

English are so confusing, grey and gray is apparent to have same meaning, but my brain apparently throw coin during typing and at some point I had code with both spelling all across code. Which I tried to unified, but this one slip from my attention.
This is a new transform which we never had before, and I add it "just in case", and "maybe it will prove useful". So i think it make sense to start from version 1.

In reply to: 205265843 [](ancestors = 205265843)

Oh sure @Ivanidzo4ka grey and gray are synonymous, though elsewhere you use gray. Also my impression is that we generally favor American spellings (gray) of words vs. British ones (grey).

...Even though I was brought up to use "grey," and had to correct myself since later in my life people thought I was weird. So now I hypercorrect, and you reap the benefits. :D

In reply to: 205597316 [](ancestors = 205597316,205265843)

TomFinley

Thank you @Ivanidzo4ka !

Ivanidzo4ka · 2018-07-31T18:37:53Z

@dotnet-bot test VSTS: public-CI

This reverts commit bdb742d.

Add images support based on System.Drawing

Ivan Matantsev added 6 commits July 2, 2018 16:22

first iteration

ba6f067

Merge branch 'master' into ivanidze/image_support

ae8f429

clean code

ffa7f12

add VectorToImage transform add first test

grayscale transform, more tests.

23f63ca

Merge branch 'master' into ivanidze/image_support

52d4f7d

small cleanup

dbf6e2a

TomFinley reviewed Jul 13, 2018

View reviewed changes

Merge branch 'master' into ivanidze/image_support

56a0b79

sfilipi reviewed Jul 16, 2018

View reviewed changes

sfilipi approved these changes Jul 16, 2018

View reviewed changes

Ivan Matantsev added 4 commits July 16, 2018 13:11

add nuget

cf0a06c

address some comment. remove SetResolution calls. unify namespace.

Merge branch 'master' into ivanidze/image_support

e5c0ab0

add entry points for ImageAnalytics

46cc8b1

update csharpApi

601bab9

disable try catch temporary

6c9df18

TomFinley reviewed Jul 17, 2018

View reviewed changes

Ivan Matantsev added 2 commits July 17, 2018 14:56

address some comments.

d97f8ae

Grayscale return exception catching

small cleanup

dbd2e42

Ivan Matantsev added 2 commits July 20, 2018 14:36

merge with master

fdd7572

more merge with master

a31a4b1

safern closed this Jul 23, 2018

safern reopened this Jul 23, 2018

Ivan Matantsev added 2 commits July 23, 2018 09:41

Merge branch 'master' into ivanidze/image_support

0c31ff7

assert not null,

50d4ac0

different image height and image width

Ivanidzo4ka closed this Jul 23, 2018

Ivanidzo4ka reopened this Jul 23, 2018

Ivan Matantsev added 2 commits July 23, 2018 13:23

bump build

516a189

Merge branch 'master' into ivanidze/image_support

23ba010

Ivanidzo4ka changed the title ~~WIP Image support~~ Image support Jul 24, 2018

Ivanidzo4ka requested a review from Zruty0 July 24, 2018 16:39

TomFinley reviewed Jul 25, 2018

View reviewed changes

Ivan Matantsev added 6 commits July 26, 2018 12:15

merge with master

e0f07f5

after merge with master

41403bc

readonly field!

75c4ba8

merge with master

48cad2d

update api and ep baselines

476ade5

merge with master

e9c59a7

TomFinley approved these changes Jul 31, 2018

View reviewed changes

Ivanidzo4ka merged commit bdb742d into dotnet:master Jul 31, 2018

Ivanidzo4ka added a commit that referenced this pull request Jul 31, 2018

Revert "Image support (#528)"

1c8c04f

This reverts commit bdb742d.

Ivanidzo4ka mentioned this pull request Aug 1, 2018

Remove agent.os demands on windows ci #621

Merged

codemzs pushed a commit to codemzs/machinelearning that referenced this pull request Aug 1, 2018

Image support (dotnet#528)

2cb7dc6

Add images support based on System.Drawing

ghost locked as resolved and limited conversation to collaborators Mar 29, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Image support #528

Image support #528

Ivanidzo4ka commented Jul 13, 2018 •

edited

Loading

TomFinley Jul 13, 2018 •

edited

Loading

TomFinley Jul 13, 2018 •

edited

Loading

TomFinley Jul 13, 2018 •

edited

Loading

TomFinley Jul 13, 2018 •

edited

Loading

TomFinley Jul 13, 2018 •

edited

Loading

TomFinley Jul 17, 2018

Ivanidzo4ka Jul 17, 2018

TomFinley Jul 13, 2018 •

edited

Loading

sfilipi Jul 16, 2018 •

edited by Ivanidzo4ka

Loading

sfilipi Jul 16, 2018 •

edited by Ivanidzo4ka

Loading

sfilipi Jul 16, 2018 •

edited by Ivanidzo4ka

Loading

sfilipi Jul 16, 2018 •

edited by Ivanidzo4ka

Loading

sfilipi Jul 16, 2018 •

edited by Ivanidzo4ka

Loading

sfilipi left a comment

Ivanidzo4ka commented Jul 16, 2018

Ivanidzo4ka commented Jul 17, 2018

TomFinley Jul 17, 2018 •

edited

Loading

TomFinley Jul 17, 2018 •

edited

Loading

Ivanidzo4ka Jul 26, 2018

TomFinley Jul 28, 2018 •

edited

Loading

Zruty0 commented Jul 25, 2018

TomFinley Jul 25, 2018 •

edited

Loading

TomFinley Jul 25, 2018 •

edited

Loading

TomFinley Jul 25, 2018 •

edited

Loading

Ivanidzo4ka Jul 26, 2018

TomFinley Jul 28, 2018 •

edited

Loading

TomFinley Jul 25, 2018 •

edited

Loading

Ivanidzo4ka Jul 26, 2018

TomFinley Jul 28, 2018

TomFinley left a comment

Ivanidzo4ka commented Jul 31, 2018


		private const string RegistrationName = "ImageGrayscale";

		/// Public constructor corresponding to SignatureDataTransform.

Image support #528

Image support #528

Conversation

Ivanidzo4ka commented Jul 13, 2018 • edited Loading

TomFinley Jul 13, 2018 • edited Loading

Choose a reason for hiding this comment

TomFinley Jul 13, 2018 • edited Loading

Choose a reason for hiding this comment

TomFinley Jul 13, 2018 • edited Loading

Choose a reason for hiding this comment

TomFinley Jul 13, 2018 • edited Loading

Choose a reason for hiding this comment

TomFinley Jul 13, 2018 • edited Loading

Choose a reason for hiding this comment

TomFinley Jul 17, 2018

Choose a reason for hiding this comment

Ivanidzo4ka Jul 17, 2018

Choose a reason for hiding this comment

TomFinley Jul 13, 2018 • edited Loading

Choose a reason for hiding this comment

sfilipi Jul 16, 2018 • edited by Ivanidzo4ka Loading

Choose a reason for hiding this comment

sfilipi Jul 16, 2018 • edited by Ivanidzo4ka Loading

Choose a reason for hiding this comment

sfilipi Jul 16, 2018 • edited by Ivanidzo4ka Loading

Choose a reason for hiding this comment

sfilipi Jul 16, 2018 • edited by Ivanidzo4ka Loading

Choose a reason for hiding this comment

sfilipi Jul 16, 2018 • edited by Ivanidzo4ka Loading

Choose a reason for hiding this comment

sfilipi left a comment

Choose a reason for hiding this comment

Ivanidzo4ka commented Jul 16, 2018

Ivanidzo4ka commented Jul 17, 2018

TomFinley Jul 17, 2018 • edited Loading

Choose a reason for hiding this comment

TomFinley Jul 17, 2018 • edited Loading

Choose a reason for hiding this comment

Ivanidzo4ka Jul 26, 2018

Choose a reason for hiding this comment

TomFinley Jul 28, 2018 • edited Loading

Choose a reason for hiding this comment

Zruty0 commented Jul 25, 2018

TomFinley Jul 25, 2018 • edited Loading

Choose a reason for hiding this comment

TomFinley Jul 25, 2018 • edited Loading

Choose a reason for hiding this comment

TomFinley Jul 25, 2018 • edited Loading

Choose a reason for hiding this comment

Ivanidzo4ka Jul 26, 2018

Choose a reason for hiding this comment

TomFinley Jul 28, 2018 • edited Loading

Choose a reason for hiding this comment

TomFinley Jul 25, 2018 • edited Loading

Choose a reason for hiding this comment

Ivanidzo4ka Jul 26, 2018

Choose a reason for hiding this comment

TomFinley Jul 28, 2018

Choose a reason for hiding this comment

TomFinley left a comment

Choose a reason for hiding this comment

Ivanidzo4ka commented Jul 31, 2018

Ivanidzo4ka commented Jul 13, 2018 •

edited

Loading

TomFinley Jul 13, 2018 •

edited

Loading

TomFinley Jul 13, 2018 •

edited

Loading

TomFinley Jul 13, 2018 •

edited

Loading

TomFinley Jul 13, 2018 •

edited

Loading

TomFinley Jul 13, 2018 •

edited

Loading

TomFinley Jul 13, 2018 •

edited

Loading

sfilipi Jul 16, 2018 •

edited by Ivanidzo4ka

Loading

sfilipi Jul 16, 2018 •

edited by Ivanidzo4ka

Loading

sfilipi Jul 16, 2018 •

edited by Ivanidzo4ka

Loading

sfilipi Jul 16, 2018 •

edited by Ivanidzo4ka

Loading

sfilipi Jul 16, 2018 •

edited by Ivanidzo4ka

Loading

TomFinley Jul 17, 2018 •

edited

Loading

TomFinley Jul 17, 2018 •

edited

Loading

TomFinley Jul 28, 2018 •

edited

Loading

TomFinley Jul 25, 2018 •

edited

Loading

TomFinley Jul 25, 2018 •

edited

Loading

TomFinley Jul 25, 2018 •

edited

Loading

TomFinley Jul 28, 2018 •

edited

Loading

TomFinley Jul 25, 2018 •

edited

Loading