Skip to content

Added getter for InputObjectDataView's Data value in documentation #5378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 31, 2020

Conversation

mstfbl
Copy link
Contributor

@mstfbl mstfbl commented Aug 31, 2020

#Fixed #5371

Added getter function to the private readonly IEnumerable<InputObject> _data to prevent call to InputObjectDataView's private value.

@mstfbl mstfbl requested a review from a team as a code owner August 31, 2020 19:48
@codecov
Copy link

codecov bot commented Aug 31, 2020

Codecov Report

Merging #5378 into master will increase coverage by 0.00%.
The diff coverage is 84.64%.

@@           Coverage Diff            @@
##           master    #5378    +/-   ##
========================================
  Coverage   74.00%   74.01%            
========================================
  Files        1019     1019            
  Lines      190163   190303   +140     
  Branches    20459    20465     +6     
========================================
+ Hits       140726   140846   +120     
- Misses      43886    43908    +22     
+ Partials     5551     5549     -2     
Flag Coverage Δ
#Debug 74.01% <84.64%> (+<0.01%) ⬆️
#production 69.76% <72.65%> (-0.01%) ⬇️
#test 87.71% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...odeGenerator/Templates/Console/ModelOutputClass.cs 29.52% <8.57%> (-4.56%) ⬇️
...erator/CodeGenerator/CSharp/TransformGenerators.cs 90.90% <80.00%> (-0.20%) ⬇️
...zureCodeGenerator/AzureAttachModelCodeGenerator.cs 96.46% <92.85%> (-2.56%) ⬇️
...odeGenerator/AzureAttachConsoleAppCodeGenerator.cs 100.00% <100.00%> (ø)
...ator/CodeGenerator/CSharp/CodeGeneratorSettings.cs 96.00% <100.00%> (+0.54%) ⬆️
.../CodeGenerator/CSharp/TransformGeneratorFactory.cs 92.00% <100.00%> (+0.33%) ⬆️
...zure/Model/AzureObjectDetectionModelOutputClass.cs 48.18% <100.00%> (ø)
...ML.CodeGenerator/Templates/Console/ConsumeModel.cs 50.73% <100.00%> (+0.24%) ⬆️
...ML.CodeGenerator/Templates/Console/ModelProject.cs 49.28% <100.00%> (+0.49%) ⬆️
....CodeGenerator/Templates/Console/PredictProgram.cs 53.12% <100.00%> (+1.29%) ⬆️
... and 8 more

@mstfbl mstfbl merged commit f9854f2 into dotnet:master Aug 31, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Mar 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cursor class attempts to access an private class member
2 participants