Skip to content

Add back missing test project from running on arcade #5545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 10, 2020
Merged

Add back missing test project from running on arcade #5545

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c17e791
add back test result upload and add missing test project from running
frank-dong-ms Dec 10, 2020
e6ff728
fix identification
frank-dong-ms Dec 10, 2020
7f65555
filter out performance test result files to avoid warnings
frank-dong-ms Dec 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions build/ci/job-template.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,21 @@ jobs:
- script: $(dotnetPath) msbuild -restore build/Codecoverage.proj
displayName: Upload coverage to codecov.io
condition: and(succeeded(), eq(${{ parameters.codeCoverage }}, True))
- task: PublishTestResults@2
displayName: Publish Test Results
condition: succeededOrFailed()
inputs:
testRunner: 'xUnit'
searchFolder: '$(Build.SourcesDirectory)/artifacts/TestResults'
# Upload all test results except performance test project. On CI by default performance tests
# will not run and test result files will still be generate without details. Avoid uploading
# performance test result to avoid warnings on publish test result stage.
testResultsFiles: |
**/*.xml
!**/*PerformanceTests*.xml
testRunTitle: Machinelearning_Tests_${{ parameters.name }}_$(_configuration)_$(Build.BuildNumber)
configuration: $(_configuration)
mergeTestResults: true
- task: CopyFiles@2
displayName: Stage build logs
condition: not(succeeded())
Expand Down
4 changes: 4 additions & 0 deletions test/Microsoft.ML.OnnxTransformerTest/Microsoft.ML.OnnxTransformerTest.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<IsUnitTestProject>true</IsUnitTestProject>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can these properties move to the test\Directory.Build.props file so they are defined for all test projects?

Copy link
Contributor Author

@frank-dong-ms-zz frank-dong-ms-zz Dec 10, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not every project under test folder is test project (for example TestFrameworkCommon) and these projects that not test project should not run during test stage. Other test projects' name are ending with Tests so they are identified as test projects by Arcade automatically and we only need to add these properties into OnnxTransformerTest and TestFramework to tell Arcade these are test projects and run them during test stage.

In reply to: 539815020 [](ancestors = 539815020)

<IsTestProject>true</IsTestProject>
</PropertyGroup>
<ItemGroup>
<ProjectReference Include="..\..\src\Microsoft.ML.Data\Microsoft.ML.Data.csproj" />
<ProjectReference Include="..\..\src\Microsoft.ML.Maml\Microsoft.ML.Maml.csproj" />
Expand Down
4 changes: 4 additions & 0 deletions test/Microsoft.ML.TestFramework/Microsoft.ML.TestFramework.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<IsUnitTestProject>true</IsUnitTestProject>
<IsTestProject>true</IsTestProject>
</PropertyGroup>
<ItemGroup>
<ProjectReference Include="..\..\src\Microsoft.ML.Core\Microsoft.ML.Core.csproj" />
<ProjectReference Include="..\..\src\Microsoft.ML.Data\Microsoft.ML.Data.csproj" />
Expand Down